Doctor able to buy bionics at the same time they are installed

[Nerdy314159265]

Describe the bug

After selecting what bionic you wish to have installed it's possible to select the bionic you are having installed in the trade menu.
The Doctor is fine with this and the installation will go as normal despite throwing an error.

Effectively the Doctor will take the item for trade and then proceed to rip a duplicate out of the empty space that will then get installed as normal.

So you get an almost free installation and the item gets duplicated. So in the case of Power Storage CBMs they can be multiplied and installed up to the cap from a single CBM.

Steps to reproduce

1. Ask the Doctor to install a CBM
2. Sell the Doctor the CBM you are having him install
3. Ignore the error message about an item being taken from the void

Expected behavior

I'd expect that the CBM you are having installed would be restricted from the trade menu or that the Doctor would refuse it.

Alternatively, it would be interesting to allow the exploit but cause the player to suffer from extra-dimensional status effects like Netherworld Attention or Teleglow.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0 2009
• Game Version: 0.F-2 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Bionic Professions [package_bionic_professions],
  Useful Helicopters [useful_helicopters]
  ]

Additional context

DEBUG : item location does not point to valid item

FUNCTION : void item_location::remove_item()
FILE : src/item_location.cpp
LINE : 895
VERSION : 0.F-2

[hexagonrecursion]

Confirmed. The doctor at the Tacoma ranch duplicates CBMs

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 34 (Thirty Four); Release: 34; Codename: ThirtyFour;
• Game Version: 9473cf6 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions]
  ]

DEBUG : item location does not point to valid item

FUNCTION : void item_location::remove_item()
FILE : src/item_location.cpp
LINE : 896
VERSION : 9473cf6

[GoLoT]

Not exactly the same issue but similar in that some conversation choices should instantly exit the conversation to avoid this kind of bug: #53244

EDIT: Actually, the fix should be the same. When a conversation action puts you under or disables you somehow, the conversation should be closed immediately.

[hexagonrecursion]

@wapcaplet confirmed