Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiclysm's Soulfire attunement enchantment indiscriminately targets neutral monsters and NPC #55397

Closed
b3brodie opened this issue Feb 15, 2022 · 6 comments · Fixed by #60894
Closed
Labels
Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@b3brodie
Copy link
Contributor

Describe the bug

The soul_pressure enchantment from Magiclysm's Soulfire attunement currently damages every nearby monster and NPC without discrimination for hostility. This makes it imposible to interact with neutral NPC's and also prevents any potential neutral animal interaction as well. I find it unlikely that this is the intended effect, but if it is more warning would be appreciated.

Steps to reproduce

  1. Acquire Soulfire attunement
  2. Stand near neutral mob or NPC
  3. Watch them burn to death

Expected behavior

Neutral Mobs and NPC's do not burn to death.

Screenshots

No response

Versions and configuration

OS: Windows 10
Game version: d08dddd
Mods Loaded:
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions],
Magiclysm [magiclysm]

Additional context

No response

@LeahLuong
Copy link

If you give a man a fire, he's warm for a night. If you set a man on fire, he's warm for the rest of his life. If you give an NPC a man whose soul is on fire, how can you expect the situation not to get heated??

@GuardianDll
Copy link
Contributor

Think the reason is because "valid_targets": [ "hostile" ], describe neutral creatures as enemies.

@DoctorGoat
Copy link
Contributor

It will also burn the gear off NPCs, which is annoying if you wanted to trade for them.

@Maleclypse Maleclypse added 0.G suggested release blocker Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod labels Feb 26, 2022
@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Mar 30, 2022
@I-am-Erk I-am-Erk added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Apr 22, 2022
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Apr 22, 2022
@I-am-Erk I-am-Erk added this to Confirmed release blockers in 0.G Stable Tracker via automation Apr 22, 2022
@I-am-Erk I-am-Erk moved this from Confirmed release blockers to Suggested release blockers in 0.G Stable Tracker Apr 22, 2022
@Maleclypse Maleclypse moved this from Suggested release blockers to Confirmed release blockers in 0.G Stable Tracker May 5, 2022
@Mer1ck
Copy link
Contributor

Mer1ck commented Jun 6, 2022

Would it be possible to add a toggle in the mutations menu? It seems like it would be a decent enough fix as opposed to redefining "hostile"

@MNG-cataclysm
Copy link
Contributor

Would it be possible to add a toggle in the mutations menu? It seems like it would be a decent enough fix as opposed to redefining "hostile"

I've tried that as a fix, it didn't work. I've been thinking about converting the enchantment into a spell, allowing the player to toggle it at will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
Development

Successfully merging a pull request may close this issue.

8 participants