Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"There is nothing to pick up." popup should not be shown when character (w)ields the only item in the (g)et menu #58473

Open
x-qq opened this issue Jun 16, 2022 · 3 comments
Labels
Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter <Suggestion / Discussion> Talk it out before implementing

Comments

@x-qq
Copy link

x-qq commented Jun 16, 2022

Is your feature request related to a problem? Please describe.

"There is nothing to pick up." popup is shown when you (w)ield an item from the (g)et menu and the wielded item was the only one in the menu. This information is already obvious and the popup is repetitive and distracting because it blocks all other input for one keypress.

Solution you would like.

Do not show the popup if the last item got wielded.

Describe alternatives you have considered.

Alternatively a log message along the lines of "There are no more items" could be shown. But I do not think it's needed either.

Additional context

No response

@x-qq x-qq added the <Suggestion / Discussion> Talk it out before implementing label Jun 16, 2022
@x-qq x-qq changed the title "Ther is nothing to pick up." popup should not be shown when character (w)ields the only item in the (g)et menu "There is nothing to pick up." popup should not be shown when character (w)ields the only item in the (g)et menu Jun 16, 2022
@NetSysFire
Copy link
Member

Might be the same underlying issue as #53526

@mqrause
Copy link
Contributor

mqrause commented Oct 27, 2022

Wield/wear closes and reopens the pickup menu. The reopening is where the popup is shown. To avoid this, it needs a method to check the number of items the menu has and only reopen it when that number minus what you're wielding is >0 (careful with partial wielding of charges). It's probably a fairly easy change.

It's unrelated to the other issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Feb 5, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2023
@NetSysFire NetSysFire reopened this Mar 7, 2023
@NetSysFire NetSysFire added (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! and removed stale Closed for lack of activity, but still valid. labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

3 participants