Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning off spell explosions where they not intended #60601

Merged
merged 3 commits into from
Sep 3, 2022

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Aug 30, 2022

Summary

None

Purpose of change

There is a lot of explosion spell effects, when there is no reason for them to be used

Describe the solution

Prevent a lof of unnecessary explosions by using NO_EXPLOSION_SFX flag (yes, it named SFX, and yes, it prevent visual effect)

Describe alternatives you've considered

Not doing it
Ask an artist to make a custom textures for each of spell (i dont think its a good thing, but i know in some tilesets it exist)

Testing

Works good imo

Additional context

Necro-boomer do not explode like nuclear warhead anymore
GIF 30 08 2022 20-04-10

Zombie child do not ignite you when you kill it
GIF 30 08 2022 20-28-23

Also i fix #60594 when i was here

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mechanics: Enchantments / Spells Enchantments and spells Monsters Monsters both friendly and unfriendly. <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Aug 30, 2022
@Ramza13
Copy link
Contributor

Ramza13 commented Aug 30, 2022

Excellent, I kept thinking I should do something like this after adding the flag, thanks for taking care of it.

@GuardianDll
Copy link
Member Author

Btw someone need to change it from SFX to VFX in the future

@Ramza13
Copy link
Contributor

Ramza13 commented Aug 30, 2022

Btw someone need to change it from SFX to VFX in the future

Ha yea I didn't even think of what the name meant just copied it form some of the code it was around.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 30, 2022
@dseguin dseguin merged commit e853744 into CleverRaven:master Sep 3, 2022
@GuardianDll GuardianDll deleted the NO_EXPLOSION_SFX branch September 3, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guilt is stopped by a fence
3 participants