Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconsolate Merc crashes game. #60938

Closed
LadyCatnip opened this issue Sep 12, 2022 · 9 comments · Fixed by #62362
Closed

Disconsolate Merc crashes game. #60938

LadyCatnip opened this issue Sep 12, 2022 · 9 comments · Fixed by #62362
Assignees
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. NPC / Factions NPCs, AI, Speech, Factions, Ownership (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@LadyCatnip
Copy link
Contributor

Describe the bug

The game Crashes when purchasing the 5-Point-Anchor from the disconsolate Merc.

Steps to reproduce

  1. Advance the game far enough along that the terminal bar will populate near the hub.
  2. Speak to the Disconsolate Merc and accept the offer to purchase the 5-Point-Anchor.
  3. Game will crash the next time you pass a turn in game.

Expected behavior

I expect the game to not crash when speaking to NPC's.

Screenshots

No response

Versions and configuration

OS: Windows 10
build type: windows-tiles-sounds-x64-msvc
build number: 2022-09-05-2002
Ingame Language: English
Mods Loaded: dda, xedra_evolved, No_Rail_Stations, no_npc_food, no_fungal_growth, StatsThroughSkills, speedydex.

Additional context

I can't fit the save here but I still have it and am able to send it over discord. I'm Catnip#6227.

@LadyCatnip LadyCatnip added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 12, 2022
@BrettDong BrettDong added <Crash / Freeze> Fatal bug that results in hangs or crashes. NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Sep 12, 2022
@Maleclypse
Copy link
Member

Will the save not fit when zipped?

@LadyCatnip
Copy link
Contributor Author

The save won't fit even when I zip it at maximum compression using 7zip. But I feel like it should be able to be recreated by someone else if they wait until the mercenaries start spawning in the 'Terminal Bar', and speak to the Disconsolate Merc.

@John-Candlebury
Copy link
Member

Cant reproduce this with the steps provided in the newest experimental.

So I'd appreciate it if you can send me the save file through discord. Im also candlebury over there

@John-Candlebury John-Candlebury self-assigned this Sep 21, 2022
@LadyCatnip
Copy link
Contributor Author

Pine Ridge 1-3.zip
Pine Ridge 2-3.zip
Pine Ridge 3-3.zip

That's the save file, extract them and put them together in the same folder.

@LadyCatnip
Copy link
Contributor Author

I was able to recreate this crash on the most recent experimental https://github.com/CleverRaven/Cataclysm-DDA/releases/tag/cdda-experimental-2022-09-21-1531 using the same mods that I was using. I used debug to advance the ingame time and retrieve the items for the Hub quests I had completed by that point in time and I managed to get that particular save file to fit in a much smaller package. Just speak to the disconsolate merc, buy the five point anchor and when you exit the conversation the game will crash.

Winsted.zip

@thomashodgkinson1987
Copy link

thomashodgkinson1987 commented Nov 12, 2022

I'm also having this same problem - once I have finished the conversation with him and I receive the anchor I cannot do the following without the game crashing:

Drop, throw, wear or weild the anchor
Moving a step

I'm not sure if he is meant to disappear after receiving the item (from the conversation/chat window I'm sure it states that he disappears quickly as soon as you get the anchor?), but he stays there. I can't find any crash log to look in to this. I've had a quick look at the JSON file "BEM_anchor_seller.json" but to be honest I haven't look at any of the games code so I wouldn't know where to start.


Edit

Sorry I forgot to say I'm using

fae2b2a (experimental build 2022-11-11-1028)
Windows 10

Mods (just normal, no extra mods):

Dark Days Ahead [dda]
Disable NPC Needs [no_npc_food]
No Fungal Growth [no_fungal_growth]
Bionic Professions [package_bionic_professions]

Using the Catapult launcher

@mqrause
Copy link
Contributor

mqrause commented Nov 24, 2022

I can't reproduce this using the Winsted save from above on f6e4f2f.

@RenechCDDA
Copy link
Member

RenechCDDA commented Nov 24, 2022

I also cannot reproduce this, compiled with VS from 43dbd7a and a downloaded copy at 25a0ca0 Able to reproduce on both, but only sporadically.

gotcha

gotcha2

(This issue was mentioned in the development discord, which is why it's receiving so much attention all at once, if you are curious!)

@I-am-Erk I-am-Erk added this to To-do in 0.G Stable Tracker via automation Nov 24, 2022
@I-am-Erk
Copy link
Member

I'm gonna close this specific issue when 62362 merges, but I would love someone to post an issue with the stuff discussed on reddit about the underlying bug. This was hard to identify and I don't want to lose that information when it comes up again.

0.G Stable Tracker automation moved this from To-do to Done Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. NPC / Factions NPCs, AI, Speech, Factions, Ownership (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
Development

Successfully merging a pull request may close this issue.

8 participants