Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy_from makes zombifies_into impossible to remove via delete #62019

Open
Karol1223 opened this issue Oct 30, 2022 · 4 comments
Open

copy_from makes zombifies_into impossible to remove via delete #62019

Karol1223 opened this issue Oct 30, 2022 · 4 comments
Labels
<Bug> This needs to be fixed Monsters Monsters both friendly and unfriendly. (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Karol1223
Copy link
Contributor

Karol1223 commented Oct 30, 2022

Describe the bug

In #61668 I made the smallest dogs not zombify. Or, well, I thought I did. The code is there, it should work. It was such a simple change I didn't even bother to test it. The problem is that now it turns out my way to remove the zombifies_into field didn't work. This was brought to light in #62008 where it turned out that copy_from and zombifies_into have a deep romance that cannot be broken by conventional means. Using delete will simply be ignored, while supposedly (I did not test that myself, however, that is what I was told is the case) setting zombifies_into to mon_null does stop the zombification while not removing the warning icon on a corpse.

Steps to reproduce

  1. Find a small dog like a beagle, a chihuahua or a dachshund
  2. Murder
  3. Notice the revival warning icon
  4. Check the code and notice that the zombifies_into should be properly removed
  5. Cry

Expected behavior

delete should not randomly lose its expected functionality on just one random field. I'd hazard a guess it doing just that isn't expected considering #61668 was approved and merged.

Screenshots

A beautiful corpse of a dachshund with a revival warning icon despite the code implying the monster shouldn't zombify.
obraz

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19043.2130 (21H1)
  • Game Version: aa2a276 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Tamable Wildlife [Tamable_Wildlife]
    ]

Additional context

Didn't test it but I think it'd be worthwhile to take a look at what happens whether a monster using copy_from from some other monster that zombifies has a zombifies_into defined but aimed at a different zombie. Which zombie will it revive as?

@Karol1223 Karol1223 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 30, 2022
@Karol1223 Karol1223 changed the title copy_from makes zombifies_into permanent with no way to remove it copy_from makes zombifies_into impossible to remove via 'delete' Oct 30, 2022
@terryjacob200
Copy link

Tested in windows-tiles-sounds-x64-2022-10-30-0948 with base DDA only. Beagle Chihuahua Dachshund all revived. Puppies of all did not revive. Is that enough or should I try "delete" on other creatures?

@Karol1223
Copy link
Contributor Author

Puppies of all did not revive.

Puppies should be unaffected since they use copy_from the labrador puppy which in itself doesn't revive, so them not reviving is expected but honestly thank god that at least that works how its expected to work.

@NetSysFire NetSysFire added <Bug> This needs to be fixed (S2 - Confirmed) Bug that's been confirmed to exist Monsters Monsters both friendly and unfriendly. and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Oct 30, 2022
@NetSysFire
Copy link
Member

NetSysFire commented Oct 30, 2022

delete does not work, but why does explicitely overwriting zombifies_into to mon_null not work either?

Edit: apparently I am dumb but there is still a tileset issue which displays the reviving corpse warning.

@irwiss
Copy link
Contributor

irwiss commented Nov 10, 2022

"zombify_into": "" should remove the revival marker

@Karol1223 Karol1223 changed the title copy_from makes zombifies_into impossible to remove via 'delete' copy_from makes zombifies_into impossible to remove via delete Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Monsters Monsters both friendly and unfriendly. (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

4 participants