Overmap Notes for Favorite Items: Not Created If Autom. Dropped

[ChromePoptart]

Describe the bug

#62299 added a global option to automatically add notes to the overmap if the player drops a favorited item. The big use case that I was excited to have this new feature implemented to help with was when items are dropped automatically, but it doesn't seem like it's functioning as I would hope.

Specifically, I usually travel wearing a big backpack with a longarm bag stashed inside in case I run across something I want to loot but won't fit in the backpack. (In case it matters, the priorities on the bags are elevated above zero, with the backpack being higher-priority than the longarm bag.) The way this usually works is:

1. I happen upon a long item while just wearing the backpack
2. I use the advanced inventory manager to try to pick up the long item
3. Since it won't fit in the backpack itself, it instead gets put into the longarm bag. Since the longarm bag was stored within the backpack, the longarm bag is then also too long to fit in the backpack, and so the longarm bag falls to the ground.
4. At this point, I'm usually paying attention to the log and/or expect the above behavior happening due to the item being long. However, every once in a while, if I'm not paying attention and running through a bunch of loot, the longarm bag with the long item will fall the ground without me realizing it. If I don't realize this for a decent amount of time, it's very difficult to remember where I was looting to know where to backtrack to to search for the longarm bag.

I tried enabling the autonote-on-dropped-favorite-item global and option doing the above steps (have on backpack containing favorited longarm bag, try to pick up long item, observe longarm bag containing long item falling to the ground). Unfortunately, the autonote is not created for the favorited longarm bag that is now on the ground.

Steps to reproduce

See above -- summarized here:

1. Enable autonote-on-dropped-favorite-item global option
2. Have on backpack containing favorited longarm bag
3. Try to pick up long item
4. Observe longarm bag containing long item falling to the ground
5. Go to overmap and observe lack of autonote

Expected behavior

I would expect that, if the global option is enabled, any method of a favorited item falling to the ground should trigger an autonote being created, whether the player manually drops a favorited item, a favorited item falls to the ground due to becoming too big for its container, etc.
Note: I did test the case of when a player becomes not strong enough to wield the currently wielded item (which is favorited), and the autonote was created in that case. So, perhaps the issue lies solely with the sequence that happens that results in a too-long-for-its-container favorited item being automatically dropped (instead of just being that the autonote is only generated when an item is manually dropped).

Screenshots

Attempting to pick up compound hunting bow leads to it going into in-backpack longarm bag, which automatically falls to the ground:

No overmap autonote is generated:

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19044.2251 (21H2)
• Game Version: 6957090 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  Blaze Industries [blazeindustries],
  Bionic Slots [cbm_slots]
  ]

Additional context

No response

[Night-Pryanik]

This is a known limit to the system. The issue you're describing happens mostly because the feature isn't working when favorited item is contained in some container. I forgot to mention it in the PR (while mentioning it in Reddit's post), sorry.

As for case when favorited item is dropped automatically, this is mostly design decision. I explicitly limited creation of autonotes only for manual dropping. E.g. player manually drops his backpack before going into a melee. Or he manually temporarily drops some of his favorited items to make space to some other item. I didn't set myself a goal to create autonote on EVERY case of dropping favorited item. Though I'm not against if someone else expanded functionally of the feature.

[ChromePoptart]

@Night-Pryanik, thank you for the clarification. Sorry that I hadn't seen the discussion on Reddit -- I was just going off of what I read in #62299.

I can understand limiting the scope of the feature. One thing I will say is that it does appear that autonotes are created in one case of automatic dropping: I tested if a wielded favorited item is dropped due to no longer having the strength/arm condition to wield it, and the autonote was created. Not sure if that was intentional or not, but I just thought I'd note it as one case where the autonotes are added with automatic dropping.

I'm not sure how to proceed with this issue then: should it change from "bug" to "discussion" or "feature request"? Or should I just close it?

[Night-Pryanik]

Don't close it, leave it as is.

[RenechCDDA]

/confirmed based on the above confirmation/posts by the PR's author

Just getting the tagging out of the way for anyone searching for things to work on in the future.

[Night-Pryanik]

Try to pick up long item

Could you please describe which long item you're trying to pick up?

[ChromePoptart]

@Night-Pryanik I describe things in a bit more detail under "describe the bug" as compared to "steps to reproduce," but I don't think I ever did explicitly state the long item I was testing with. The specific containers I'm using are a high-volume rucksack and a longarm bag. Since I have the two "compression straps/tool loop" pockets disabled ("items won't be inserted") via "pocket settings", the high-volume rucksack pocket with the longest capacity is pocket 1 with 29 inches. So, while wearing the high-volume rucksack, with the longarm bag contained in pocket 1, trying to pick up any item that is longer than 29 inches results in the item being inserted into the longarm bag and then the longarm bag automatically falling to the ground. If it matters, the specific "long item" I was using during testing was a compound hunting bow (length 59 inches).