Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asking ally where to build faction camp fails (invalid reference TALK_ALLY_TUTORIAL_CAMP_LOCATION) #62951

Open
mikegogulski opened this issue Jan 1, 2023 · 1 comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@mikegogulski
Copy link
Contributor

Describe the bug

There appear to be two ways to ask your allies where you can build a faction camp:

  1. Say something like "let's start a camp here" at a place where it's not allowed. The NPC will say so, and you can then ask "Since we can't build a camp here, where can we build a camp?". This leads into a dialogue at data/json/npcs/TALK_FACTION_CAMP.json:TALK_CAMP_SITES that looks like it enumerates the valid locations.
  2. Just ask where you can start a camp. This fails with the error message below. It looks like TALK_ALLY_TUTORIAL_CAMP_LOCATION might need to be TALK_CAMP_SITES instead. TALK_ALLY_TUTORIAL_CAMP_LOCATION doesn't appear to be used anywhere other than as a subtopic in TALK_CAMP_TUTORIAL_INTRO, so it's effectively an invalid reference.

The error:

 DEBUG    : I don't know what to say for TALK_ALLY_TUTORIAL_CAMP_LOCATION. (BUG (npctalk.cpp:dynamic_line))

 FUNCTION : dynamic_line
 FILE     : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\npctalk.cpp
 LINE     : 1140
 VERSION  : e171fb3

Steps to reproduce

With an allied NPC:

  1. (t)alk
  2. (f) help/tutorial
  3. (d) faction camps
  4. (a) how faction camps work
  5. (e) tell me where we can build one
  6. The error report above appears.

Expected behavior

The same dialogue train as in (1) in the description is followed.

Screenshots

No response

Versions and configuration

OS: Win11
Version: 2022-12-27-e171fb3
Tiles
English
Mods: all of them

Additional context

No response

@MNG-cataclysm
Copy link
Contributor

/confirmed

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

2 participants