Scrap Meat Has No Iron(UPDATE:ALL FOODS MISSING 1 BASE VITAMIN?!)

[Grubleafeater]

Describe the bug

Scraps of meat have effectively no iron. When frying them, using 10 meat, I get a hunk of fried meat with ONE percent iron. (Edit:The iron was from the oil. Scrap meat had no contribution.)

Attach save file

N/A

Steps to reproduce

Butcher creature, get scrap meat, cook scrap meat into fried meat

Expected behavior

Scrap meat should have 10% of the iron that chunk meat does, and for that matter a shred of calcium as chunked meat has a tiny bit, too.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19044.2604 (21H2)
• Game Version: 95521e0 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions],
  Xedra Evolved [xedra_evolved],
  Magiclysm [magiclysm],
  Blaze Industries [blazeindustries],
  SpeedyDex [speedydex],
  Stats Through Kills [stats_through_kills],
  Stats Through Skills [StatsThroughSkills],
  My Sweet Cataclysm [my_sweet_cataclysm]
  ]

Additional context

No response

[Owlfren]

The 12% is "of RDI", recommended daily intake, not a percentage of the total or anything like that. Since scrap of meat is a tenth of the weight chunk is it would in fact appear to be accurate on that count. 12% for 300g is a bit on the low end for iron in meat mind you, but I expect that was the choice since we put all the meats in the same category.

[Grubleafeater]

The 12% is "of RDI", recommended daily intake, not a percentage of the total or anything like that. Since scrap of meat is a tenth of the weight chunk is it would in fact appear to be accurate on that count. 12% for 300g is a bit on the low end for iron in meat mind you, but I expect that was the choice since we put all the meats in the same category.

You misunderstand.

1 chunk is 12%. 10 scraps are 1% total. Individually they have no listed iron.

[Grubleafeater]

The 12% is "of RDI", recommended daily intake, not a percentage of the total or anything like that. Since scrap of meat is a tenth of the weight chunk is it would in fact appear to be accurate on that count. 12% for 300g is a bit on the low end for iron in meat mind you, but I expect that was the choice since we put all the meats in the same category.

You misunderstand.

1 chunk is 12%. 10 scraps are 1% total. Individually they have no listed iron.

Ah, hang on. The 1% is from the animal oil. Apologies. 10 scraps are 0%.

[Owlfren]

Can confirm, scraps of meat whether spawned in or gain from butchery do not contain any iron. Tested by spawning 20 cooked and eating, butchering a deer and then cooking ten that I ate and eating another ten raw. Waiting an hour after each, then checking vitamins. No iron.
Scraps of meat appear to have no iron despite json saying 1.

[Grubleafeater]

Crosschatter on Discord says that it appears that the base foods are all missing 1 of each vitamin. Combining them works just fine, dividing them does too, but chocolate bars are supposed to have 8 of calcium and iron and only have 7.

[pjf]

Base foods missing 1 of each vitamin would also explain why young leaves and burdock don't display any vitamin C, despite having 1% RDI each in the JSON files.

[pjf]

/confirmed

[Kamayana]

It seems that RDA_to_default's conversion from RDA to the game's internal vitamin units (which I believe are at equilibrium at 96, rather than the 100 of RDA) has issues with floating points numbers getting converted into integers. An RDA value of 1% gets converted into 0.959999 which gets rounded to 0 after converting it to an integer, an RDA value of 23% gets rounded to 22.079999 which rounds to 22, and so on.

The function itself returns a float, but that gets immediately converted into an int since the nutrients struct stores vitamin values as integers: std::map<vitamin_id, int> vitamins;

In addition, this conversion is used before displaying RDA values when examining an item, rather than showing the RDA value like one would expect, so all those values are off as well.

I'm not sure how best to handle these issues. Rounding vitamin values between 0-1 up to 1 would fix the biggest problem of 1% vitamins being completely absent, but that wouldn't fix all the vitamin values being slightly off, and I don't understand the internal vitamin units well enough to make a judgement call. I'd like to request @bombasticSlacks give their input, since they overhauled vitamins in #59722 and could help determine what to do here.

[bombasticSlacks]

Had to reread that PR lol, yeah it's 96 not 100 because it's on time ticks and that works out to 15 minute ticks. Easiest (and fine solution) is just to ceil the value so that you get a little more than correct rather than a little less.