Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when autotravel in vehicle #63928

Open
cookins opened this issue Mar 4, 2023 · 7 comments
Open

Error when autotravel in vehicle #63928

cookins opened this issue Mar 4, 2023 · 7 comments
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@cookins
Copy link

cookins commented Mar 4, 2023

Describe the bug

When autotravel in vehicle - error showing up. It can happen when auto travel or start autotravel.

Attach save file

space adventure-trimmed.tar.gz

Steps to reproduce

  1. Get in vehicle, start control
  2. Open map and plot auto travel
  3. Confirm autotravel
  4. Ride

Expected behavior

Expected as supposed autotravel to be

Screenshots

No response

Versions and configuration

Android from play market, version: d6ec466

Additional context

No response

@cookins cookins added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 4, 2023
@irwiss
Copy link
Contributor

irwiss commented Mar 5, 2023

It's not strictly an error, but "Can't see a path forward" and "Auto drive canceled" messages.

Looks like vehicle::autodrive_controller::compute_path fails to find a path, don't have time to dig deeper now but attached save seems to be replicating the problem well

Fwiw it should be returning a path so it's some unhandled edgecase bug

Moving the vehicle forward 3 tiles makes autodrive work again

@dseguin dseguin added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Mar 5, 2023
@cookins
Copy link
Author

cookins commented Mar 6, 2023

I was asked in discord to post it here. Done.

@cookins cookins closed this as completed Mar 6, 2023
@irwiss
Copy link
Contributor

irwiss commented Mar 6, 2023

this shouldn't be closed, the bug is still there

@cookins cookins reopened this Mar 6, 2023
@cookins
Copy link
Author

cookins commented Mar 6, 2023

this shouldn't be closed, the bug is still there

So bug afterall 😄

@andrei8l
Copy link
Contributor

andrei8l commented Mar 6, 2023

It's not strictly an error, but "Can't see a path forward" and "Auto drive canceled" messages.

Looks like vehicle::autodrive_controller::compute_path fails to find a path, don't have time to dig deeper now but attached save seems to be replicating the problem well

Fwiw it should be returning a path so it's some unhandled edgecase bug

Moving the vehicle forward 3 tiles makes autodrive work again

This is the error

(continued from above) ERROR : /home/runner/work/Cataclysm-DDA/Cataclysm-DDA/android/app/jni/src/../../../../src/map_memory.cpp:256 [const mm_submap &map_memory::get_submap(const tripoint &) const] Called map_memory with an 

from debug.log.prev in OP archive. I haven't been able to reproduce it. My best guess is that it can happen on small screens after a quicksave but before the next game::draw() call.

Screenshot from OP on discord

image0

@cookins
Copy link
Author

cookins commented Mar 6, 2023

In true, i don't have that error anymore. I drove 15 times after - all fine... Guess it was faulty start, maybe

@qoreQyaS
Copy link
Contributor

qoreQyaS commented Apr 7, 2023

i just had this happening on b836ae3 right after starting autotravel in a tractor on linux/debian with tileset.

 DEBUG    : Called map_memory with an 

 FUNCTION : const mm_submap& map_memory::get_submap(const tripoint&) const
 FILE     : src/map_memory.cpp
 LINE     : 256
 VERSION  : b836ae3
- OS: Linux
    - OS Version: Distributor ID: Debian; Description: Debian GNU/Linux 12 (bookworm); Release: 12; Codename: bookworm; 
    - Debian: unstable/sid
- Game Version: b836ae3 [64-bit]
- Graphics Version: Tiles Ultica/Larwick overmap
- Game Language: System language [] en_US
- Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Bombastic Perks [bombastic_perks],
    My sidebar [sidebarfoo]
]

relevant part debug log(plus 1 line above):

14:25:49.357 ERROR SDL : src/sdlsound.cpp:360: Failed to load audio file /home/sgrewe/bin/dda/userdata/sound/Otopack+ModsUpdates/music/carpenterbrut_turbokiller: Couldn't open '/home/sgrewe/bin/dda/userdata/sound/Otopack+ModsUpdates/music/carpenterbrut_turbokiller'
16:45:12.757 ERROR : src/map_memory.cpp:256 [const mm_submap& map_memory::get_submap(const tripoint&) const] Called map_memory with an
16:52:28.458 ERROR : src/map_memory.cpp:256 [const mm_submap& map_memory::get_submap(const tripoint&) const] Called map_memory with an
16:52:29.105 ERROR : src/map_memory.cpp:256 [const mm_submap& map_memory::get_submap(const tripoint&) const] Called map_memory with an
16:52:29.497 ERROR : src/map_memory.cpp:256 [const mm_submap& map_memory::get_submap(const tripoint&) const] Called map_memory with an
16:52:30.074 ERROR : src/map_memory.cpp:256 [const mm_submap& map_memory::get_submap(const tripoint&) const] Called map_memory with an
[ Previous repeated 251 times ]
16:52:30.111 ERROR : src/map_memory.cpp:256 [const mm_submap& map_memory::get_submap(const tripoint&) const] Called map_memory with an

Quivero-trimmed.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

5 participants