Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-from cannot properly carry over (or overwrite?) LIST requirements listed in components field #63931

Open
Karol1223 opened this issue Mar 4, 2023 · 5 comments
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Karol1223
Copy link
Contributor

Karol1223 commented Mar 4, 2023

Describe the bug

#62843 is having peculiar test failures related to crafting requirement groups in specific recipes. On the devcord, it was brought up that these specific armors have had this problem before already and it is assumed to be caused by copy_from integration between them. I was advised to report this. I am now smarter and can see things as they truly are. I know copy-from is evil. So I can now fully say that this is an issue with copy-from and requirement groups using "LIST" under the components field of the recipe. I am not sure whether the problem is that these requirements cannot be overwritten, or because they just do not want to carry over, but I know they're at fault.

Attach save file

N/A, but my hubris is recorded in the commit history of #62843

Steps to reproduce

  1. Create a new recipe that uses copy-from from a recipe which already has "LIST" requirement groups under component field (such as armor_blarmor)
  2. Under the components field of the new recipe, add the same requirement group that the copied recipe uses
  3. Watch the chaos

Expected behavior

Errors bad :(

Screenshots

No response

Versions and configuration

N/A

Additional context

No response

@Karol1223 Karol1223 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 4, 2023
@Karol1223 Karol1223 mentioned this issue Mar 4, 2023
@bombasticSlacks
Copy link
Contributor

image
The erros mentioned

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 4, 2023
@Karol1223 Karol1223 changed the title Weird errors with copy_from in specific armor recipes Weird errors with copy-from in specific armor recipes Apr 8, 2023
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Apr 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label May 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
@harakka
Copy link
Contributor

harakka commented Oct 7, 2023

/confirm
For ease of reference here is a direct link to the errors in question https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/6419674496/job/17430035850?pr=62843#step:20:52

Just a thought but it might help debugging if there was a minimal test mod with save included that reproduces this on loading. That is, if these emerge in game and not just in test runs

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid. labels Oct 7, 2023
@github-actions github-actions bot reopened this Oct 7, 2023
@Karol1223 Karol1223 changed the title Weird errors with copy-from in specific armor recipes copy-from cannot properly carry over (or overwrite?) LIST requirements listed in components field Oct 20, 2023
@Karol1223
Copy link
Contributor Author

I opted to update this issue with the newfound knowledge I obtained while working on the wax PR. I think in this state the problem at hand is at least visible, and maybe it gets fixed at some point. I do admit the first iteration of this issue was less than helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

3 participants