Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI incorrectly reports solar panels as cause of slow movement when walking in vehicle #65221

Open
GlitterLich opened this issue Apr 21, 2023 · 1 comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist Vehicles Vehicles, parts, mechanics & interactions

Comments

@GlitterLich
Copy link
Contributor

GlitterLich commented Apr 21, 2023

Describe the bug

On a vehicle tile consisting of only a frame, a roof and a solar panel, the UI's log will report "Moving onto/off this solar panel is slow!", whereas the actual cause of slowdown is the naked frame sitting underneath it.

Attach save file

N/A

Steps to reproduce

  1. Make a vehicle tile consisting of only a frame, a roof and a solar panel
  2. Walk on/off it

Expected behavior

The UI should properly report that "Moving onto/off this frame is slow!" instead.

Screenshots

N/A

Versions and configuration

Windows 7 64bit
0.G stable

Additional context

No response

@GlitterLich GlitterLich added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Apr 21, 2023
@GlitterLich GlitterLich changed the title UI incorrectly shows solar panels as cause of slow movement when walking in vehicle UI incorrectly reports solar panels as cause of slow movement when walking in vehicle Apr 22, 2023
@RenechCDDA
Copy link
Member

Confirmed, and yes this could be more accurate with information given to the player. Right now it's just pulling the display part, which is why solar panels and not roofs trigger it. (The roof is actually unnecessary and doesn't interact in any way)

Cataclysm-DDA/src/game.cpp

Lines 10305 to 10311 in a2f5875

if( slowed && !u.is_mounted() ) {
// Unless u.pos() has a higher movecost than dest_loc, state that dest_loc is the cause
if( mcost_to >= mcost_from ) {
if( auto displayed_part = vp_there.part_displayed() ) {
add_msg( m_warning, _( "Moving onto this %s is slow!" ),
displayed_part->part().name() );
sfx::do_obstacle( displayed_part->part().info().get_id().str() );

@RenechCDDA RenechCDDA added (S2 - Confirmed) Bug that's been confirmed to exist Vehicles Vehicles, parts, mechanics & interactions and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

No branches or pull requests

2 participants