Solid items can put pocketed into pressurised tanks where they would be rendered unobtainable

[Jazzofthesoul]

Describe the bug

Solid items can put pocketed into pressurised tanks where they would be rendered unobtainable

Attach save file

N/A

Steps to reproduce

1. have empty pressurised tanks
2. grab an inventory full of supplies
3. items end up in tanks where they are trapped unable to be unloaded or used

Expected behavior

items wouldn't go into the tanks as they are not a liquid or gas

Screenshots

Versions and configuration

OS: windows 10
Build: experimental, 2023-04-21-1828
Tiles

Additional context

No response

[RenechCDDA]

This is true, and it's a direct result of the NO_UNLOAD flag.

This is because pressurized tanks are the default container for pure liquid ammonia, which shouldn't be able to exist outside of its pressure tanks. When I previously worked on the container I considered adding NO_RELOAD so you couldn't put things back in it but... it doesn't make much sense (or feel very 'fair') to have the container only be emptyable once.

I don't see any good way to combine the requirements of "don't allow the ammonia to escape" with "allow the container to be reuseable (for any valid item that can go into it)" without new logic. That said, I would like to note that you can get ammonia outside of pressurized tanks by crafting it - at which point it acts just like any other liquid and can be transferred between waterproof containers at will.

[PatrikLundell]

One way to work around the problem of being able to put the gas into the tank without allowing anything else to be put into the tank would be to have appropriate crafting recipes that take tanks as ingredients to deliver filled tanks as the result. This has the obvious issue of requiring one recipe for each type of tanks and product (because of the current way recipes work).

The longer term solution would probably be crafting logic that allowed recipes to pick containers for its products as ingredients and deliver products that were those same kinds of containers (or the actual container items) filled with the produced fluid/gas. That would also allow for (basecamp) companion crafting of fluids. I don't know whether this ought to replace or merely supplement the current construction process of first producing the liquid/gas and then find something to pour it into, but I'm leaning towards replacement.

[anoobindisguise]

You can retrieve the items by running it over with a car (carefully) but yeah it's silly. I used to use them to store HGCs due to massive weight limits and NPCs still bought them at full price despite them being locked in stasis lol.

[RenechCDDA]

The longer term solution would probably be crafting logic that allowed recipes to pick containers for its products as ingredients and deliver products that were those same kinds of containers (or the actual container items) filled with the produced fluid/gas.

I really like this specific idea for ammonia, it would also eliminate the current situation where you can craft ammonia and pour it into any sort of container. By requiring an existing pressure tank and resulting in the tank filled with it, we can essentially keep ammonia 'locked down'.

It wouldn't directly solve it for saltpeter (which produces ammonia as a byroduct) but with all the crafting improvements from mqrause we can specify byproducts popping out into their own containers... so maybe there's a way?

[MrHrulgin]

Just ran across this issue. As of now, it's impossible to [U]nload it, but if you use the AIM system to enter the pressurized tank as a container, you can move the solids out of it.