Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urns and memorial items spawn in bookstore shelves #65450

Closed
CuteCottonCandyCat opened this issue May 3, 2023 · 1 comment · Fixed by #66490
Closed

Urns and memorial items spawn in bookstore shelves #65450

CuteCottonCandyCat opened this issue May 3, 2023 · 1 comment · Fixed by #66490
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON (S2 - Confirmed) Bug that's been confirmed to exist Spawn Creatures, items, vehicles, locations appearing on map

Comments

@CuteCottonCandyCat
Copy link

Describe the bug

After clearing out a bookstore of its books, I saw that the items recovered included alcohol, a beaded bracelet, and an urn full of ash.

Attach save file

Century Village-trimmed.tar.gz

Steps to reproduce

  1. Find bookstore.
  2. Find memorial items on shelves that wouldn't be expected in a bookstore.

Expected behavior

It's expected that bookstores would typically lack human memorial remains.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22621.1555 (22H2)
  • Game Version: 5dec493 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    No Rail Stations [No_Rail_Stations],
    SpeedyDex [speedydex],
    Stats Through Skills [StatsThroughSkills],
    Generic Guns [generic_guns],
    Stats Through Kills [stats_through_kills],
    Tamable Wildlife [Tamable_Wildlife],
    No Fungal Monsters [No_Fungi]
    ]

Additional context

No response

@CuteCottonCandyCat CuteCottonCandyCat added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 3, 2023
@RenechCDDA
Copy link
Member

Bah this is an ugly one with nested groups. You're located in a s_bookstore_2_east but even after generating new ones with the map editor several times and viewing them through clairvoyance, nothing of the sort spawns (including in the lockers). I also manually went through the item groups to find any ways this could be possible and was unable to. Just in case my manual search was not exhaustive I used the ingame item group tester to give me examples of all the item groups that spawn in that mapgen and the closest was maple syrup in the snacks groups.

Finally after exhaustively going through the item groups I found the culprit was mansion_books. Still couldn't ID the nested group so I went through and again tested the item groups inside mansion_books... exhaustively......

It stems from memorial_mansion being part of mansion_books.

{ "group": "memorial_mansion", "prob": 10 }

"entries": [
{ "item": "corpse_ash", "prob": 100, "charges-min": 1905, "charges-max": 3969, "container-item": "crystal_urn" },
{ "item": "photo_album", "prob": 80 },
{ "item": "bouquet", "prob": 80 },
{ "item": "candlestick", "prob": 50, "charges-min": 1, "charges-max": 6 },
{ "group": "liquor_and_spirits", "prob": 60 },
{ "group": "wines_worthy", "prob": 50 },
{ "item": "cigar", "prob": 50 },
{ "group": "jewelry_accessories", "prob": 50 }

@RenechCDDA RenechCDDA added (S2 - Confirmed) Bug that's been confirmed to exist Spawn Creatures, items, vehicles, locations appearing on map and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels May 6, 2023
@Maleclypse Maleclypse added Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON (S2 - Confirmed) Bug that's been confirmed to exist Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
3 participants