-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The item categories of tanks (as in containers) are inconsistent and follows no discernable pattern. #67607
Comments
Empty tanks should be containers, in my opinion. (partially) Filled tanks should go into whatever category their contents place them in (when not containing multiple kinds), while containers containing mixed contents ought to go into a mixed content container group. |
i can work on this in a few days. creating a new item category. i'd appreciate it if you can help me a bit and list more of the problematic items |
I'd probably prefer things loaded into things without significant work to mount them and with the purpose of being emptied to be treated as "magazines" (with the exception of batteries and ammunition loaded directly into weapons). I don't think it would be good to separate weapon magazines from other magazines, because there might be situations where something would end up matching both categories (akin to how batteries span categories). I'd like to see empty pressurized tanks etc. to go into containers if they can be refilled, and into "other" (or "garbage that be recycled as best") if there's no process that allow them to be reused. That's somewhat error prone in that someone who decides to make a recipe to reuse such items should also have to know to update the item category, but I think that's better than to fool the player into thinking there is some use for spent containers that have no further use. I think a number of breathing filters have changed from using filter insets with charges to require the construction of new filters (possible with the spent filter assembly as a component) when they are spent. I wouldn't want those to end up in clothing as they provide no benefit but only disadvantages when worn while spent, and so ought to go into "other". |
The lists below were produced by loading a fairly advanced save and trundling though all the crafting recipes available. Weapon/Magazines:
Armor (ignoring scabbards and other dedicated "holding stuff" clothing) NO ISSUES SEEN IN THIS SECTION:
Other:
|
Thank you, i will start working on it sometime in a few days. |
i don't think pots should be categorized as containers, no? they're more of a tool than a container Also, can you remove the correctly listed ones in your list? there is no need to change them if they're correct |
Pots are a marked as TBD because I'm not sure whether they should be tools or containers. Regardless, all of them should be in the same category. Stripped away the "correct" stuff from the post above, and assumed pots should remain in tools. Other: |
Describe the bug
Different categories for tanks in the game:
It's hard to find the tanks when you sort your zone by category.
I wasn't sure whether to categorize this as a suggestion or bug report, but having pressurized tank categorized as WEAPONS can't be intended.
Attach save file
N/A
Steps to reproduce
N/A
Expected behavior
Either:
General metal tanks or pressurized tanks without any associated tool can be containers and take the category of their content.
Screenshots
Versions and configuration
Dark Days Ahead [dda]
]
Additional context
Also, for welding tools:
Batteries should maybe also be in the same category as tanks, whatever that may be.
The text was updated successfully, but these errors were encountered: