Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezing on a load screen. (NPC? related) #72495

Open
Radonchnk opened this issue Mar 19, 2024 · 3 comments
Open

Freezing on a load screen. (NPC? related) #72495

Radonchnk opened this issue Mar 19, 2024 · 3 comments
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Radonchnk
Copy link

Describe the bug

I belie this bug is connected in some way to NPCs crafting spikes and going into infinite loop.
So when i was playing i gave spike craft to NPCs and while being in the same tile i start reading book. Then game stater lagging at 21:55 (roughly) after which game started saving (22:58 game time). After multiple minutes of waiting i decided to kill program.
Now when i load game is it stack on "Finalizing" step (at maximum core load)
Couldn't get save from debug menu, so tar-ed it

Attach save file

https://drive.google.com/file/d/1raTFNthpoFwidnX1GqywTOivih0QrKoU/view?usp=sharing

Steps to reproduce

Put into saves folder, run game, select save

Expected behavior

I expect dda to work, but it does not

Screenshots

image

Versions and configuration

version - 9733666
OS - linux mint
CPU - 11th Gen Intel i3-1115G4 (4) @

Additional context

No response

@Radonchnk Radonchnk added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 19, 2024
@RenechCDDA
Copy link
Member

I was able to load your save after marking "Shauna Donnelly" as dead. Their current activity is ACT_MULTIPLE_CRAFT. Profiling indicates it's stuck on... item::stacks_with?

@RenechCDDA RenechCDDA added Code: Performance Performance boosting code (CPU, memory, etc.) (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Mar 20, 2024
@Radonchnk Radonchnk closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@Radonchnk Radonchnk reopened this Mar 20, 2024
@Radonchnk
Copy link
Author

That is not the first time i have issues with NPCs and crafts.
One way i used to deal with this before was to move away couple tiles and than return to NPCs after they finished crafting

@RenechCDDA
Copy link
Member

RenechCDDA commented Mar 20, 2024

I've made a trimmed version of the save, both with and without the dead NPC edit applied for ease of testing.
NO_LOAD_ALIVE.tar.gz
NO_LOAD_DEAD-trimmed.tar.gz

Dunno how much more help I can be with this. I see that the crafting inventory is invalidated every move and rebuilt, which is basically 100% of the problem, but I don't know why this would be a problem specifically with your save.

Though you do have tens of thousands of pieces of trash items scattered about, which I am sure is a contributing factor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

2 participants