Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGui - ImTui support on tiled builds #73011

Open
katemonster33 opened this issue Apr 14, 2024 · 3 comments
Open

ImGui - ImTui support on tiled builds #73011

katemonster33 opened this issue Apr 14, 2024 · 3 comments
Labels
Code: Build Issues regarding different builds and build environments Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@katemonster33
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Right now, ImGui drawing logic is split into two very different implementations, SDL and ImTui. In order to test ImTui we need to load up a curses build on Linux and we are running low on devs willing/able to do this.

Solution you would like.

Rework ImTui to hook it into CDDA's existing curses-SDL bridge logic. This would solve two issues for us, one being that we could appease users who want the UI to look similar to how it did, and two, we could test ImTui without needing people to build curses on Linux.

This would be an option under the options menu, something like "ImGui backend - SDL/ImTui"

Describe alternatives you have considered.

Resurrect the Windows pdcurses-based non-tiled build. I have no idea if ImTui even works with pdcurses.

Additional context

No response

@katemonster33 katemonster33 added the <Suggestion / Discussion> Talk it out before implementing label Apr 14, 2024
@RenechCDDA RenechCDDA added Info / User Interface Game - player communication, menus, etc. Code: Build Issues regarding different builds and build environments Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds labels Apr 14, 2024
@Qrox
Copy link
Contributor

Qrox commented Apr 15, 2024

The curses version can be built with ImTUI and ncurses using MSYS2 on Windows, although I'm not sure if it works anymore with ImGUI added.

Resurrect the Windows pdcurses-based non-tiled build.

Which build are you refering to? The MSYS2 build I mentioned above and the obsolete wincurse port both use the ncurses API. In fact the ImTUI source code seems to be using pdcurses.

@katemonster33
Copy link
Contributor Author

Which build are you refering to? The MSYS2 build I mentioned above and the obsolete wincurse port both use the ncurses API. In fact the ImTUI source code seems to be using pdcurses.

I was talking about wincurse, I thought it used pdcurses, maybe not

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
Status: Todo
Development

No branches or pull requests

3 participants