Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGui windows. Using different fonts in one sentence #73061

Open
IdleSol opened this issue Apr 16, 2024 · 1 comment
Open

ImGui windows. Using different fonts in one sentence #73061

IdleSol opened this issue Apr 16, 2024 · 1 comment
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (S2 - Confirmed) Bug that's been confirmed to exist SDL: Tiles / Sound Tiles visual interface and sounds.

Comments

@IdleSol
Copy link

IdleSol commented Apr 16, 2024

Describe the bug

While still in the process of creating report #72986, I noticed a strange behavior of exclamation (!) and question (?) marks.

Now, I have additional comments. Therefore, I am putting it in a separate topic.

1. As it was on the old interface (?). Version 2024-04-04-0557. ImGui = false

  • Russian
    test1

  • English
    test2

Notice. The entire phrase is in the same style (same font). And it is on one line (one level).

2. New interface. ImGui = true. English.

  • Version 2024-04-11-2208
    3
    4

Pay attention to the question mark at the end of the sentence. He is clearly a half a line higher.

  • Version 024-04-16-1009
    t1

Maybe it's just me, but in this version, the font of the text and the question mark are different.

3. New interface. ImGui = true. Russian.

  • Version 2024-04-11-2208
    1
    2

For context. First screenshot: You stand in thin smoke. Second: stop moving items. Problems with buttons are indicated in #72986

Notice that the question mark is at the same level as the text. But now there is a problem with the exclamation mark. In the second screenshot, instead of the - sign you got _.

  • Version 024-04-16-1009
    t2

Notice. Two different fonts are used. The first font is for the entire message. The second one is for the number of threads to be received: 50. And also 50 is half a line lower than the word нитки (threads).

UPD. I didn't pay attention right away. There's also a problem with brackets. They are obviously lower than they should be.

Attach save file

N/A

Steps to reproduce

N/A

Expected behavior

I want the messages, as well as the game as a whole, to use a consistent style.

Screenshots

No response

Versions and configuration

cdda-windows-tiles-x64-2024-04-16-1009

Additional context

Additional information #72986 (comment)

Right, and for the question mark question, when I wrote #72579, I had to make some artificial adjustments to the x/y coordinates when drawing to the screen from an imgui call. I'm still not sure why this needed to be done. It's possible that the adjustment I made to get CJK characters to look ok doesn't work for Cyrillic. Yes it's a separate issue, you can make an issue if you want, but I don't know how easy it will be to fix

@IdleSol IdleSol added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Apr 16, 2024
@NetSysFire NetSysFire added (S2 - Confirmed) Bug that's been confirmed to exist SDL: Tiles / Sound Tiles visual interface and sounds. ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Apr 22, 2024
@NetSysFire
Copy link
Member

Can confirm.

image

Maaaybe also related to #73120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (S2 - Confirmed) Bug that's been confirmed to exist SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
Status: Todo
Development

No branches or pull requests

2 participants