Survivor harness + M110A1. I can stow the rifle in the harness, but I can't add it to the whitelist.

[IdleSol]

Describe the bug

I noticed that the rifle fits in the harness. But I can't select it in the white list so it always fits in the harness.

Attach save file

n/a

Steps to reproduce

1. Create a survivor harness https://cdda-guide.nornagon.net/item/survivor_vest
2. Create M110A1 rifle+4
3. Remove the silencer so that the length satisfies the strapping restrictions
4. Stow the rifle in the harness
5. Open the pocket settings
6. Try to add it to the white list

Expected behavior

Ability to add a rifle to the whitelist

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19043 (21H1)
• Game Version: cdda-experimental-2024-04-23-0642 a662bd5 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth]
  ]

Additional context

No response

[RenechCDDA]

The issue is that it's checking against a newly initialized item of that itype, with all the baggage that comes with it. (Simplified explanation) So for the M110A1 specifically it's spawning a new one out of thin air, comparing it(with suppressor) to the pocket, and saying it won't fit. Then despawning that newly made one after saying you can't whitelist the item, because it wouldn't fit.

Cataclysm-DDA/src/item_contents.cpp

Line 344 in 709ea9f

if( !listed_itypes.count( id ) && selected_pocket->is_compatible( item( id ) ).success() ) {