Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ter_furn_transform doesn't check result is valid on load #73438

Open
Procyonae opened this issue May 1, 2024 · 1 comment
Open

ter_furn_transform doesn't check result is valid on load #73438

Procyonae opened this issue May 1, 2024 · 1 comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@Procyonae
Copy link
Contributor

Procyonae commented May 1, 2024

Describe the bug

ter_furn_transforms aren't correctly/sufficiently being validated on load

Attach save file

N/A

Steps to reproduce

  1. Add a nonsense result to a ter_furn_transform eg:
  {
    "type": "ter_furn_transform",
    "id": "invalid_transform",
    "terrain": [
      { "result": "should_cause_an_error", "valid_terrain": [ "t_wall" ] }
    ]
  }
  1. Load the game and get no errors

Expected behavior

Validity checks resulting in errors

Screenshots

No response

Versions and configuration

N/A

Additional context

No response

@Procyonae Procyonae added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 1, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

1 participant