Tile spawning error

[IdleSol]

Describe the bug

Mostly incorrect tile placement. Some points may be debatable.

1. house_detatched5_north. Should be linoleum, just like the rest of the tiles.
   

2. bungalow23_west. Reverse situation. Linoleum is located here, but there should be a regular floor: floor.
   

3. house_34_west. Under the flowerpot, there should be a floor. With the pantry, it's a moot point. There is linoleum located there. I think it should be the same floor as the rest of the house.
   

4. house_38_west. Under the flowerpot, there should be a floor.
   

5. gambling_hall_south. We need linoleum.
   

6. urban_10_1_south. A piece of pavement in the house and pantry.
   

Attach save file

1.test-trimmed.tar.gz
2.test-trimmed.tar.gz
3.test-trimmed.tar.gz
4.test-trimmed.tar.gz
5.test-trimmed.tar.gz
6.test-trimmed.tar.gz

Steps to reproduce

n/a

Expected behavior

n/a

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19043 (21H1)
• Game Version: cdda-experimental-2024-05-03-1808 0a74bb4 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth]
  ]

Additional context

No response

[IdleSol]

7. hous_wooded_north. Linoleum must be placed under the bathtub.
   

8. s_restaurant_coffee_east. Linoleum is missing again.
   

9. house_porch_basement_south. And here we forgot about the carpet.
   

10. house_37_east. Apparently flower pots don't like regular floors.
    

11. basement. Just a basement? No numbers or specifics. There's concrete under the boxes instead of a floor.
    

UPD. I forgot to attach the files

7.test-trimmed.tar.gz
8.test-trimmed.tar.gz
9.test-trimmed.tar.gz
10.test-trimmed.tar.gz
11.test-trimmed.tar.gz

[IdleSol]

I have two questions:

1. Is there an easy way to get all the buildings on one map, without repeats? Something like creating a test world.

2. Those who are engaged in creating new maps. Are you comfortable working with such a system? I mean, how in one section you have to specify: terrain, furniture, items and the rest? Wouldn't it be easier to divide them into at least two sections? One for the building itself, where only structures would be included, and the other for the rest? Perhaps with monster spawning separated into a third section?

[PatrikLundell]

1. There is debug support where you can specify what an overmap should contain, so you could presumably specify them one beside the other from the list the overmap editing tool provides you with. It's obviously tedious if you want to get the lot, but doable. Beyond that I'd assume it would be possible to add code that does that, although the problem is for the code to "know" what to place and what to skip (just going through all of them probably creates a rather odd mix of housing and terrain). You also have the issue of things that are larger than a single tile.
2. I'm not making new maps, but separating things into layers brings another issue with it: namely alignment. As soon as you decide to shift a part of the structure you'll have to go to the other layers and shift them accordingly.

In bungalow23 I think the creator thought specifying t_null as map terrain would override the bathroom terrain, but instead it does nothing, i.e. leaves the terrain as it was before and allows you to add other parameters (such as furniture or items). You can't reuse palettes containing furniture and erase the terrain. Instead, you have to use a palette that doesn't specify any terrain (or replace the reused characters with free glyphs, i.g. replace 'Q' for the rack with something unused and add it to the furniture section, and '~' would similarly have to be replaced as it's a bathroom one).

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[casswedson]

/confirmed /good-first-issue

the hardest part is finding the mapgen ids with errors so this is pretty straightforward