Unloading action does not work properly for gases

[osuphobia]

Describe the bug

When unloading a container with gases in it using auto mode, the whole bulk of gases is treated as an item, if you don't have a container that is big enough to hold all of the charges, not a single charge will be added to your pockets.
Unloading using manual mode works better, but still not perfect and will cause a bug.

Attach save file

N/A

Steps to reproduce

1. Wield an extra large gastank full of biogases, and put a small gastank in your backpack.
2. Try to unload the large tank using manual mode, see the small tank only be partly filled.
3. Try again, and the debugmsg popped up.
4. Try to unload the large tank using auto mode, get informed that there is no enough room in your inventory, and lost all the gases.

Expected behavior

Be able to unload gases properly

Screenshots

2024-05-06.120104.mp4

2024-05-06.121135.mp4

Versions and configuration

• OS: Windows
  • OS Version: 10.0.22631.3447 (23H2)
• Game Version: eefe407 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth]
  ]

Additional context

#73543
We may need something like the liquid_handler but for gases.

[PatrikLundell]

What happens if you use the container fill interface instead?

This is for a potential work around, not suggested as a solution (and if that doesn't work properly either, we've got another issue that needs fixing as well).

[osuphobia]

What do you mean by "the container fill interface", the reload item interface?
The biogas tanks are not watertight, and have pocket type CONTAINER, with item_restriction defined.
I meant to make it only airtight, so you can't see it in the reload interface.
Anyway, even if you add watertight to the tank, you are still not able to reload it with gas.
If you also change the pocket type to magazine and define ammo_restriction, the reload action works fine, but now you can't gather biogas from the digester.
And, if you only replace item_restriction with ammo_restriction, the (manual) unload action works, you can still gather biogas from the digester, but a display error will occur.

[PatrikLundell]

Sorry, I meant the refill interface, and you answered that question.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.