Map falls apart after update

[Void-Seeker]

Describe the bug

With cdda-experimental-2024-06-19-1355 db4fb60 provided save file loads correctly, but on latest update map is corrupted, character is inside the wall, their vehicle is inside a wall, it's a mess.

Attach save file

Квойн-trimmed.tar.gz

Steps to reproduce

1. Load provided save file in latest version (cdda-experimental-2024-06-20-0230 c0e4c91) and in cdda-experimental-2024-06-19-1355 db4fb60

Expected behavior

Not corrupting the map, i guess...

Screenshots

Versions and configuration

• OS: Linux
  • OS Version: Distributor ID: Linuxmint; Description: Linux Mint 21.2; Release: 21.2; Codename: victoria;
• Game Version: cdda-experimental-2024-06-20-0230 c0e4c91 [64-bit]
• Graphics Version: Tiles
• Game Language: Русский <color_dark_gray>(89,3%) [ru]
• Mods loaded: [
  Тёмные Дни Впереди [dda],
  Отключить потребности у НПС [no_npc_food],
  Портальные штормы игнорируют НПС [personal_portal_storms],
  Медленный рост фунгалоидов [no_fungal_growth],
  иконки видит-игрока, бег, приседание, кровотечение для retrodays [sees_player_retro],
  Характеристики за навыки [StatsThroughSkills],
  Характеристики за убийства [stats_through_kills],
  Скорость от ловкости [speedydex]
  ]

Additional context

config.zip

[Void-Seeker]

After messing around I've determined that the version that breaks the map is cdda-experimental-2024-06-19-1857 e4840ea. Last working one is cdda-experimental-2024-06-19-1635 5f78795. #74169 is probably a reason.

[PatrikLundell]

/Confirmed

It seems a number of overmaps are rotated compared to what they should be.
It can be noted that the facility is a mess of different rotations inherently, both when loaded with an old exe and a new one, so the cause seems to be that something rotates some of the overmaps again, not that the rotations are specified incorrectly with the new exe (the west side consists of east sections with a rotation of 1, the east side consists of west sections with a rotation of 3, the facility itself has a rotation of 3, and the parking area has a rotation of 2).

It's also raining monsters with the new exe (monsters spawned up in the air).

Edit:

• The monster rain is caused by a bug applying the monster generation of the ground level to all levels. Easily fixed.
• The rotation is somehow caused by the regeneration of the uniform roof above (commenting out generation causes the loaded save to load the ground level correctly, but there is now null terrain where much of the roof should be). Why and how to fix that remains to figure out.

[Void-Seeker]

Yeah, it's really weird that monsters respawned on the new version. That locaation was mostly cleared of monsters, there shouldn`t be many monsters left, especially on the surface. Monsters respawning on already cleared location might be separate issue.