Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container audit (mostly transparency) #73458

Merged
merged 3 commits into from
May 3, 2024

Conversation

Brambor
Copy link
Contributor

@Brambor Brambor commented May 2, 2024

Summary

Balance "Make most plastic and glass containers transparent"

Purpose of change

Working on #73400 revealed that containers are not transparent (apart from two exceptions). The most notable non-transparent containers are a plastic bag and a plastic bottle.

Some containers didn't make sense.

  • tankard_wooden wasn't an open container, so you could transport coffee in it in your bag
    • image
  • camelbak, which is a hydration pack was rigid
    • image

Describe the solution

I went through all containers in items/containers/containers.json and added "transparent": true where it made sense. If it had a URL in "//", I looked at that, if not, I often googled it. If at least half of the pictures were transparent, I made it transparent - my rationale is a benefit of the doubt, the non-transparent container will be more annoying to work with in the future, I think.

  • Made tankard_wooden "open_container": true.
  • Removed "rigid": true from camelbak.

Describe alternatives you've considered

Testing

TODO: Rebased #73400 onto this and enjoyed that I can see inside the containers (meaning they don't indicate hides content, which means they are transparent.)

  1. Merge with / rebase onto Show NEW! in List Items menu #73400.
  2. Spawn all items inside containers.
  3. View Item List.
  4. Sort it by category.
  5. Scroll to the food category.
  6. Go over all items, so they are not NEW!.
  7. Observe if "hides contents" make sense.
    • It does.
      • Things like paper wrapper and tin can (sealed) still hide contents
      • While plastic bottle, glass bottle, and plastic bag don't hide contents.
    • image

Additional context

  • bag_plastic_small is watertight, so you can put water in it, put it on the ground or in a bag and it won't spill
    • image

I didn't believe the bag would hold liquid, so I took one IRL, filled it with water and it didn't leak! Marvellous!

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 2, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 3, 2024
@Maleclypse Maleclypse merged commit 90d6620 into CleverRaven:master May 3, 2024
24 checks passed
@Brambor Brambor deleted the container-audit branch May 3, 2024 10:28
TheAthenaCabin0 added a commit to TheAthenaCabin0/Cataclysm-DDA that referenced this pull request May 14, 2024
With the change of hydration pack to a non-rigid container, when filled
up to its maximum volume of water, it would expand excessively to 6 L,
as opposed to its approximate 3250 mL maximum volume (as calculated by
@Hyperseeker.
references CleverRaven#73508, references CleverRaven#73458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants