CES Lorenz example for JOSS paper #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 88.09% 88.16% +0.07%
==========================================
Files 7 7
Lines 1134 1124 -10
==========================================
- Hits 999 991 -8
+ Misses 135 133 -2 ☔ View full report in Codecov by Sentry. |
odunbar
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Thanks for the work! Looking good so far, I had a few small comments and this main point:
- I feel the walkthrouh is unfinished, could you add the points detailed below, such as adding snippets for building of machine learning tools / emulators, and building and running of MCMC? Including the "get_posterior" call to obtain the results from the chain object.
odunbar
reviewed
Nov 28, 2023
There was a problem hiding this comment.
Thanks for the update! This looks much better! The main points of this review:
- There is still a gap where we jump from defining the prior, to defining the emulator, perhaps it would be good to discuss (briefly) EKI in between and move up the calibration results to come before the discussion of emulators
- You can be a bit more judicious with the snippets, some have unnecessary lines (e.g.
savefigorprintlnstatements, while other snippets mention items that aren't explained (e.g.optimizer_options = overridesinRF-scalar)
odunbar
approved these changes
Dec 11, 2023
odunbar
changed the title
docs build docs build docs build docs build some updates to Lorenz example documentation commit before rebase removed manifest.toml files added results figures to docs added results figures to docs remove manifest finished description of emulate_sample.jl in docs quick format fix quick typo fix reorganized to more clearly explain the calibrate and emulate_sample stages small typo on file title
|
NB I have rebased and force-pushed to enable merge into main. No other changes have been made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #255
Content
Docs can be found here.