Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix parameter name bug for MV distributions, cap mac-os tests to julia v1.9.0 #277

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jan 24, 2024

Purpose

MCMCChains requires one name per dimension for MCMC diagnostics. This causes an error when Multivariate distributions are used. This PR fixes this bug.

Content

  • uses the dimension of prior distribution in MCMC to clone the name e.g. a 3D "u" -> ["u_1","u_2","u_3"]
  • adds a quick unit-test for a case where #names < #prior dimensions

Misc

  • using sqrt(C) * MVNormal(0,I) instead of MVNormal(0,C)
  • for an unknown reason, the Mac tests with v1.9.1 onwards are hanging on the package build of CES, so capping at v1.9.0

  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a621a04) 88.09% compared to head (e991cbe) 88.05%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   88.09%   88.05%   -0.05%     
==========================================
  Files           7        8       +1     
  Lines        1134     1172      +38     
==========================================
+ Hits          999     1032      +33     
- Misses        135      140       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odunbar odunbar changed the title Bugfix parameter name bug for MV distributions Bugfix parameter name bug for MV distributions, cap mac-os tests to julia v1.9.0 Jan 26, 2024
@odunbar
Copy link
Collaborator Author

odunbar commented Jan 27, 2024

Small bugfixes with unit tests, and buildkite passing with unchanged results.

@odunbar odunbar merged commit b6a80c9 into main Jan 29, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant