Inline copyto! to fix Ref allocations
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/allocs
branch
from
e6f3e53
to
ecba6a7
Compare
|
Thanks for the investigatory work, @simonbyrne! |
charleskawczynski
changed the title
copyto! to fix Ref allocations
charleskawczynski
force-pushed
the
ck/allocs
branch
from
ecba6a7
to
5e4e14e
Compare
|
bors r+ |
|
bors r- |
|
Canceled. |
bors bot
added a commit
that referenced
this pull request
Sep 15, 2022
945: Inline `copyto!` to fix Ref allocations r=charleskawczynski a=charleskawczynski This PR applies ``@inline`` to `copyto!`, which was found to fix allocations with `Ref`s inside broadcast expressions, and adds tests. I'm going to try this out with ClimaAtmos to see if one more minor change is needed, too. This fixes our `bycolumn` allocations with `Ref`s from 24576 bytes to 0. Closes #946. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 15, 2022
945: Inline `copyto!` to fix Ref allocations r=charleskawczynski a=charleskawczynski This PR applies ``@inline`` to `copyto!`, which was found to fix allocations with `Ref`s inside broadcast expressions, and adds tests. I'm going to try this out with ClimaAtmos to see if one more minor change is needed, too. This fixes our `bycolumn` allocations with `Ref`s from 24576 bytes to 0. Closes #946. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
|
Oops, looks like that doesn't pass the allocation tests with |
charleskawczynski
force-pushed
the
ck/allocs
branch
from
5e4e14e
to
b68990f
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 15, 2022
945: Inline `copyto!` to fix Ref allocations r=charleskawczynski a=charleskawczynski This PR applies ``@inline`` to `copyto!`, which was found to fix allocations with `Ref`s inside broadcast expressions, and adds tests. I'm going to try this out with ClimaAtmos to see if one more minor change is needed, too. This fixes our `bycolumn` allocations with `Ref`s from 24576 bytes to 0. Closes #946. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 3, 2022
978: Extend and fix Ref broadcasting with StencilCoefs r=charleskawczynski a=charleskawczynski This PR extends and fixes `Ref` broadcasting with StencilCoefs (#963), solution was basically the same as the one applied in #945. Closes #963. I tried applying only `copyto!`, and only `apply_stencil!`, but that didn't work so I applied to all three methods. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 3, 2022
978: Extend and fix Ref broadcasting with StencilCoefs r=charleskawczynski a=charleskawczynski This PR extends and fixes `Ref` broadcasting with StencilCoefs (#963), solution was basically the same as the one applied in #945. Closes #963. I tried applying only `copyto!`, and only `apply_stencil!`, but that didn't work so I applied to all three methods (which does work). Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 4, 2022
978: Extend and fix Ref broadcasting with StencilCoefs r=charleskawczynski a=charleskawczynski This PR extends and fixes `Ref` broadcasting with StencilCoefs (#963), solution was basically the same as the one applied in #945. Closes #963. I tried applying only `copyto!`, and only `apply_stencil!`, but that didn't work so I applied to all three methods (which does work). Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 4, 2022
978: Extend and fix Ref broadcasting with StencilCoefs r=charleskawczynski a=charleskawczynski This PR extends and fixes `Ref` broadcasting with StencilCoefs (#963), solution was basically the same as the one applied in #945. Closes #963. I tried applying only `copyto!`, and only `apply_stencil!`, but that didn't work so I applied to all three methods (which does work). Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 4, 2022
978: Extend and fix Ref broadcasting with StencilCoefs r=charleskawczynski a=charleskawczynski This PR extends and fixes `Ref` broadcasting with StencilCoefs (#963), solution was basically the same as the one applied in #945. Closes #963. I tried applying only `copyto!`, and only `apply_stencil!`, but that didn't work so I applied to all three methods (which does work). Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 4, 2022
978: Extend and fix Ref broadcasting with StencilCoefs r=charleskawczynski a=charleskawczynski This PR extends and fixes `Ref` broadcasting with StencilCoefs (#963), solution was basically the same as the one applied in #945. Closes #963. I tried applying only `copyto!`, and only `apply_stencil!`, but that didn't work so I applied to all three methods (which does work). Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Oct 4, 2022
978: Extend and fix Ref broadcasting with StencilCoefs r=charleskawczynski a=charleskawczynski This PR extends and fixes `Ref` broadcasting with StencilCoefs (#963), solution was basically the same as the one applied in #945. Closes #963. I tried applying only `copyto!`, and only `apply_stencil!`, but that didn't work so I applied to all three methods (which does work). Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies
@inlinetocopyto!, which was found to fix allocations withRefs inside broadcast expressions, and adds tests. I'm going to try this out with ClimaAtmos to see if one more minor change is needed, too.This fixes our
bycolumnallocations withRefs from 24576 bytes to 0.Closes #946.