Allocations in broadcasts with Ref #946
Labels
bug
Something isn't working
Comments
bors bot
added a commit
that referenced
this issue
Sep 15, 2022
945: Inline `copyto!` to fix Ref allocations r=charleskawczynski a=charleskawczynski This PR applies ``@inline`` to `copyto!`, which was found to fix allocations with `Ref`s inside broadcast expressions, and adds tests. I'm going to try this out with ClimaAtmos to see if one more minor change is needed, too. This fixes our `bycolumn` allocations with `Ref`s from 24576 bytes to 0. Closes #946. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this issue
Sep 15, 2022
945: Inline `copyto!` to fix Ref allocations r=charleskawczynski a=charleskawczynski This PR applies ``@inline`` to `copyto!`, which was found to fix allocations with `Ref`s inside broadcast expressions, and adds tests. I'm going to try this out with ClimaAtmos to see if one more minor change is needed, too. This fixes our `bycolumn` allocations with `Ref`s from 24576 bytes to 0. Closes #946. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this issue
Sep 15, 2022
945: Inline `copyto!` to fix Ref allocations r=charleskawczynski a=charleskawczynski This PR applies ``@inline`` to `copyto!`, which was found to fix allocations with `Ref`s inside broadcast expressions, and adds tests. I'm going to try this out with ClimaAtmos to see if one more minor change is needed, too. This fixes our `bycolumn` allocations with `Ref`s from 24576 bytes to 0. Closes #946. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
We're incurring allocations in broadcast statements involving the use of
Ref.The text was updated successfully, but these errors were encountered: