Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupled Timestepping Interface #16

Merged
merged 10 commits into from
Sep 15, 2021
Merged

Coupled Timestepping Interface #16

merged 10 commits into from
Sep 15, 2021

Conversation

jb-mackay
Copy link
Contributor

@jb-mackay jb-mackay commented Sep 2, 2021

Introduces the coupled timestepping interface in which component models provide step! methods used in the coupled system driver. Updates to coupler state interface will occur in a separate PR.

To do:

  • Implement basic run! function that executes simulation timestepping
  • Update unit tests
  • Coupled atmos-ocean-land example implementation (Future PR)
  • Update dependencies
  • Update docs

@jb-mackay jb-mackay self-assigned this Sep 2, 2021
@jb-mackay jb-mackay linked an issue Sep 2, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #16 (e937d7d) into main (d548586) will increase coverage by 7.97%.
The diff coverage is 47.05%.

❗ Current head e937d7d differs from pull request most recent head 555713f. Consider uploading reports for the commit 555713f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   57.14%   65.11%   +7.97%     
==========================================
  Files           4        4              
  Lines          63       43      -20     
==========================================
- Hits           36       28       -8     
+ Misses         27       15      -12     
Impacted Files Coverage Δ
src/CoupledSimulations/coupled_simulation.jl 0.00% <0.00%> (ø)
src/CouplerMachine.jl 100.00% <ø> (ø)
src/CouplerState/coupler_state.jl 72.72% <62.50%> (ø)
src/CoupledSimulations/clock.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d548586...555713f. Read the comment docs.

@jb-mackay jb-mackay marked this pull request as ready for review September 13, 2021 20:22
@jb-mackay
Copy link
Contributor Author

Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to remove the ClimateMachine-compatible interface completely though? I wonder whether it's still useful to keep it somewhere until have a way to support the CM with the new interface. I guess we can always go back the commit history once we come to that bridge though...

@jb-mackay
Copy link
Contributor Author

jb-mackay commented Sep 15, 2021

Looks good! Do we want to remove the ClimateMachine-compatible interface completely though? I wonder whether it's still useful to keep it somewhere until have a way to support the CM with the new interface. I guess we can always go back the commit history once we come to that bridge though...

@LenkaNovak I think it is straightforward to use the new interface with a ClimateMachine simulation via ODESolvers.general_dostep!.

@jb-mackay jb-mackay merged commit 5fd0aa2 into main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Model/Simulation Abstraction
2 participants