-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coupled Timestepping Interface #16
Conversation
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 57.14% 65.11% +7.97%
==========================================
Files 4 4
Lines 63 43 -20
==========================================
- Hits 36 28 -8
+ Misses 27 15 -12
Continue to review full report at Codecov.
|
Documentation preview: https://clima.github.io/CouplerMachine/previews/PR16/couplerstate/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Do we want to remove the ClimateMachine-compatible interface completely though? I wonder whether it's still useful to keep it somewhere until have a way to support the CM with the new interface. I guess we can always go back the commit history once we come to that bridge though...
@LenkaNovak I think it is straightforward to use the new interface with a ClimateMachine simulation via |
Introduces the coupled timestepping interface in which component models provide
step!
methods used in the coupled system driver. Updates to coupler state interface will occur in a separate PR.To do:
run!
function that executes simulation timesteppingCoupled atmos-ocean-land example implementation(Future PR)