Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore w/ vscode artifacts #324

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Update .gitignore w/ vscode artifacts #324

merged 2 commits into from
Jun 15, 2023

Conversation

valeriabarra
Copy link
Member

Purpose

Updates .gitignore to add the artifacts generated by the VScode editor (which most of us use)

Content

  • Updated .gitignore

Review checklist

  • I have read and checked the items on the review checklist.

@valeriabarra
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 15, 2023
@bors
Copy link
Contributor

bors bot commented Jun 15, 2023

try

Build failed:

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should also open an issue describing that NCDatasets v0.12.17 has breaking changes and we need to update for them and revert this compat accordingly.

@valeriabarra
Copy link
Member Author

Looks good. We should also open an issue describing that NCDatasets v0.12.17 has breaking changes and we need to update for them and revert this compat accordingly.

Sounds good. Do you mind doing that? If not, just let me know and I'll do it

@valeriabarra
Copy link
Member Author

bors r+

@valeriabarra
Copy link
Member Author

NCDatasets v0.12.17 has breaking changes

okay, done.
#325

@bors
Copy link
Contributor

bors bot commented Jun 15, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 9c35361 into main Jun 15, 2023
6 checks passed
@bors bors bot deleted the valeria/gitignore branch June 15, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants