Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prescribing 3d fields from files #506

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Enable prescribing 3d fields from files #506

merged 1 commit into from
Nov 28, 2023

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Nov 17, 2023

Closes #507


  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak force-pushed the ln/3d-regrid branch 2 times, most recently from 4f2e7c7 to 1529283 Compare November 17, 2023 23:15
@LenkaNovak LenkaNovak marked this pull request as ready for review November 20, 2023 20:00
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I mostly requested more comments :) thank you Lenka!

src/Regridder.jl Outdated Show resolved Hide resolved
src/Regridder.jl Outdated Show resolved Hide resolved
test/Project.toml Outdated Show resolved Hide resolved
test/regridder_tests.jl Outdated Show resolved Hide resolved
test/regridder_tests.jl Outdated Show resolved Hide resolved
test/regridder_tests.jl Show resolved Hide resolved
src/Regridder.jl Outdated Show resolved Hide resolved
src/Regridder.jl Outdated Show resolved Hide resolved
@LenkaNovak
Copy link
Collaborator Author

Looks good! I mostly requested more comments :) thank you Lenka!

Thank you for the review, @juliasloan25 ! I've addressed your comments. Please lmk if there's anything else.

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the changes!

2d works

4d works

add to src anf test

clean up

add deps

typo

revs

regrid 3d init

2d works

4d works

add to src anf test

clean up

add deps

typo

revs

fix rebase
@LenkaNovak LenkaNovak merged commit db2c8df into main Nov 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable prescribing 3d fields from files
2 participants