debug CommonDataModel bug #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/common-data
branch
2 times, most recently
from
3a26adf
to
0630130
Compare
LenkaNovak
approved these changes
May 13, 2024
There was a problem hiding this comment.
LGTM, @juliasloan25. Just a quick comment on how to generalize the truncation to other than 3D datasets. After fixing the paths for the CI runs and double checking the visualized output is the same as on main, then feel free to merge.
juliasloan25
force-pushed
the
js/common-data
branch
from
0630130
to
2628b42
Compare
anastasia-popova
approved these changes
May 13, 2024
juliasloan25
force-pushed
the
js/common-data
branch
from
2628b42
to
c063dc9
Compare
juliasloan25
force-pushed
the
js/common-data
branch
from
c063dc9
to
d85c8bb
Compare
juliasloan25
force-pushed
the
js/common-data
branch
from
d85c8bb
to
735296e
Compare
juliasloan25
force-pushed
the
js/common-data
branch
from
735296e
to
6629838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #765
I'm not exactly sure what caused the bug, but in v0.3.6 CommonDataModel's extension of
Base.writewas changed here. I'm not sure what about this change caused the behavior change, but changing the dataset creation to avoid usingwriteworks fine.Note: buildkite is failing because of a bug in RRTMGP that was fixed in v0.13.2. #738 updates to use that version, so after that's. merged in I'll rebase and merge this PR.
Content
time_start/time_end->t_start/t_endfor more consistency throughout the code and easier REPL debugging