update Manifest to use registered ClimaLSM #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jb-mackay @LenkaNovak for visibility - will return to this once we release another ClimaLSM. |
kmdeck
changed the title
|
@kmdeck what other dependencies are requiring us to check in the Manifest for this experiment? If just LSM, we could remove the Manifest as long as the |
|
we actually can use the current registered ClimaLSM if we upgrade the version of atmos we are using (I think) - I saw a PR in ClimaAtmos that bumps the compat of CA to include 0.7 for Interval sets, which is what ClimaLSM uses. We may not need to check in the Manifest, Im not sure. Would the above still cause an issue, though? If CA and CLSM have compat entries that do not overlap? |
kmdeck
force-pushed
the
clima_lsm_reg_version
branch
from
7a1ab39
to
eae4195
Compare
|
Outdated and addressed in #143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Purpose and Content
Upgrade Manifest to use ClimaLSM - registered version
Note that when I went to do so, there was a conflict between the IntervalSets compat in ClimaAtmos and ClimaLSM. I am broadening the compat in ClimaLSM to overlap with ClimaAtmos. That is the branch that is currently used in this PR. But, I'd like to wait to release another version of ClimaLSM until there are more changes, so this is on hold.