absorbed radiation is not zero if LAI is zero #646
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #645
We compute transmitted radiation as proportional to exp(-KLAIOmega), where Omega is O(1). The absorbed radiation is proportional to (1- exp(-KLAIOmega)).
When the sun is at the horizon, K ~ 1/eps(FT), and no radiation is transmitted (the extinction coefficient K -> infinity).
However, when LAI -> 0, we need to have exp(-KLAIOmega) -> 1, so absorbed radiation -> 0. The issue is that if LAI is O(eps(FT)), K*LAI ~O(1), and absorbed radiative fraction is O(1/e).
Solution:
Im not sure. I dont understand the behavior of K with zenith angle
To-do
deal with 1/cos(theta) when theta = pi/2
deal with exp(-K*LAI) when K ~ 1/eps(FT) (from 1/cos(theta)) and LAI ~ eps(FT)
Content
added failing test