Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absorbed radiation is not zero if LAI is zero #646

Closed
wants to merge 3 commits into from

Conversation

kmdeck
Copy link
Collaborator

@kmdeck kmdeck commented Jun 7, 2024

Purpose

Fixes #645
We compute transmitted radiation as proportional to exp(-KLAIOmega), where Omega is O(1). The absorbed radiation is proportional to (1- exp(-KLAIOmega)).

When the sun is at the horizon, K ~ 1/eps(FT), and no radiation is transmitted (the extinction coefficient K -> infinity).

However, when LAI -> 0, we need to have exp(-KLAIOmega) -> 1, so absorbed radiation -> 0. The issue is that if LAI is O(eps(FT)), K*LAI ~O(1), and absorbed radiative fraction is O(1/e).

Solution:
Im not sure. I dont understand the behavior of K with zenith angle

To-do

deal with 1/cos(theta) when theta = pi/2
deal with exp(-K*LAI) when K ~ 1/eps(FT) (from 1/cos(theta)) and LAI ~ eps(FT)

Content

added failing test


  • I have read and checked the items on the review checklist.

@kmdeck kmdeck self-assigned this Jun 7, 2024
@kmdeck
Copy link
Collaborator Author

kmdeck commented Jun 7, 2024

@Espeer5 in case you have any ideas, but I can implement/try and fix

@kmdeck
Copy link
Collaborator Author

kmdeck commented Jul 3, 2024

Im closing this PR because for now we are clipping LAI

@kmdeck kmdeck closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roundoff error in two stream scheme
1 participant