Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single-layer BigLeafHydraulics Model #619

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

Espeer5
Copy link
Collaborator

@Espeer5 Espeer5 commented May 15, 2024

Purpose

See #599 The existing PlantHydraulics model requires large vectors of data giving the heights of layers in the canopy. This functionality is unused and we have no plans to utilize it in the future. The purpose of this PR is to create a simple plant hydraulics model which is a single stem and leaf compartment, removing the need for that data.

To-do

  • Convert all experiments to use BigLeafHydraulicsModel
  • Convert all tutorials to use BigLeafHydraulicsModel
  • Add a test comparing BigLeafHydraulicsModel to PlantHydraulicsModel
  • Validate boundary conditions caught by lai_consistency_check are equal for both models

Content

  • BigLeafHydraulics model created implementing same functionality as PlantHydraulicsModel

  • I have read and checked the items on the review checklist.

@Espeer5 Espeer5 force-pushed the es/BigLeafHydraulics branch 8 times, most recently from a99ae93 to d65cca4 Compare May 15, 2024 20:49
@Espeer5 Espeer5 force-pushed the es/BigLeafHydraulics branch 2 times, most recently from b77108a to 5dcdf01 Compare June 2, 2024 07:40
@Espeer5 Espeer5 force-pushed the es/BigLeafHydraulics branch 4 times, most recently from edd5408 to 2cc90f4 Compare June 2, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant