Skip to content

Commit

Permalink
Removes manual grid manipulation in VerticallyStretchedRectilinearGri…
Browse files Browse the repository at this point in the history 
…d constructor (#1755)

* Removes manual grid manipulation in VerticallyStretchedRectilinearGrid constructor

* Bump to 0.58.5
  • Loading branch information
@glwagner
glwagner committed Jun 22, 2021
1 parent 5550049 commit 1f9d6d1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Oceananigans"
uuid = "9e8cae18-63c1-5223-a75c-80ca9d6e9a09"
version = "0.58.4"
version = "0.58.5"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
4 changes: 0 additions & 4 deletions src/Grids/vertically_stretched_rectilinear_grid.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,6 @@ function VerticallyStretchedRectilinearGrid(FT = Float64;
Δzᵃᵃᶠ = OffsetArray(Δzᵃᵃᶠ, -Hz)
Δzᵃᵃᶜ = OffsetArray(Δzᵃᵃᶜ, -Hz)

# Needed for pressure solver solution to be divergence-free.
# Will figure out why later...
Δzᵃᵃᶠ[Nz] = Δzᵃᵃᶠ[Nz-1]

# Seems needed to avoid out-of-bounds error in viscous dissipation
# operators wanting to access Δzᵃᵃᶠ[Nz+2].
Δzᵃᵃᶠ = OffsetArray(cat(Δzᵃᵃᶠ[0], Δzᵃᵃᶠ..., Δzᵃᵃᶠ[Nz], dims=1), -Hz-1)
Expand Down

3 comments on commit 1f9d6d1

@glwagner
Copy link
Member Author

@glwagner glwagner commented on 1f9d6d1 Jun 22, 2021 •
edited by navidcy
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

  • Removes manual manipulation of grid metrics in constructor for VerticallyStretchedRectilinearGrid that may have lowered the order of accuracy or invalidated some calculations

@navidcy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

  • Removes manual manipulation of grid metrics in constructor for VerticallyStretchedRectilinearGrid that may have lowered the order of accuracy or invalidated some calculations

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/39434

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.58.5 -m "<description of version>" 1f9d6d1e3744c4956b1fb397501b17cfa5fe3f08
git push origin v0.58.5

Please sign in to comment.