Skip to content

Commit

Permalink
Merge pull request #2220 from CliMA/glw/fix-slice-ensembles
Browse files Browse the repository at this point in the history
  • Loading branch information
navidcy committed Feb 4, 2022
2 parents 10b860a + 1a99eb0 commit d857f77
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Oceananigans"
uuid = "9e8cae18-63c1-5223-a75c-80ca9d6e9a09"
version = "0.69.4"
version = "0.69.5"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const CoriolisVector = AbstractVector{<:AbstractRotation}
@inline y_f_cross_U(i, j, k, grid::YZSliceGrid, coriolis::CoriolisVector, U) = @inbounds y_f_cross_U(i, j, k, grid, coriolis[i], U)
@inline z_f_cross_U(i, j, k, grid::YZSliceGrid, coriolis::CoriolisVector, U) = @inbounds z_f_cross_U(i, j, k, grid, coriolis[i], U)

function FFTImplicitFreeSurfaceSolver(arch, grid::YZSliceGrid, settings)
function FFTImplicitFreeSurfaceSolver(grid::YZSliceGrid, gravitational_acceleration::Number, settings)

grid isa HRegRectilinearGrid ||
throw(ArgumentError("FFTImplicitFreeSurfaceSolver requires horizontally-regular rectilinear grids."))
Expand All @@ -86,12 +86,13 @@ function FFTImplicitFreeSurfaceSolver(arch, grid::YZSliceGrid, settings)

sz = SliceEnsembleSize(size=(grid.Ny, 1), ensemble=grid.Nx, halo=(grid.Hy, 0))

horizontal_grid = RectilinearGrid(; topology = (Flat, TY, Flat),
size = sz,
halo = grid.Hy,
y = y_domain(grid))
horizontal_grid = RectilinearGrid(architecture(grid);
topology = (Flat, TY, Flat),
size = sz,
halo = grid.Hy,
y = y_domain(grid))

solver = FFTBasedPoissonSolver(arch, horizontal_grid)
solver = FFTBasedPoissonSolver(horizontal_grid)
right_hand_side = solver.storage

return FFTImplicitFreeSurfaceSolver(solver, grid, horizontal_grid, right_hand_side)
Expand Down

2 comments on commit d857f77

@navidcy
Copy link
Collaborator Author

@navidcy navidcy commented on d857f77 Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/53859

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.69.5 -m "<description of version>" d857f777f0ed300c3b989e70179e220e713084f3
git push origin v0.69.5

Please sign in to comment.