Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are cells "wet", "dry", "active", or "inactive"? #2833

Closed
glwagner opened this issue Nov 18, 2022 · 0 comments · Fixed by #2918
Closed

Are cells "wet", "dry", "active", or "inactive"? #2833

glwagner opened this issue Nov 18, 2022 · 0 comments · Fixed by #2918
Labels
cleanup 🧹 Paying off technical debt

Comments

@glwagner
Copy link
Member

This abstraction:

Oceananigans.jl/src/Coriolis/hydrostatic_spherical_coriolis.jl

Line 58 in 4b4bef7

const CoriolisWetCellEnstrophyConserving = HydrostaticSphericalCoriolis{<:WetCellEnstrophyConservingScheme}

introduces the synonyms "wet/dry" for the existing semantics "active/inactive".

I think we should pick one and use it.

@simone-silvestri
@glwagner glwagner added the cleanup 🧹 Paying off technical debt label Nov 18, 2022
@glwagner glwagner changed the title Are cells "wet" or "active" Are cells "wet", "dry", "active", or "inactive"? Nov 18, 2022
@navidcy navidcy mentioned this issue Feb 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes wet/dry to active/inactive CliMA/Oceananigans.jl
1 participant
@glwagner