Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute_regionally must be deprecated #3386

Closed
navidcy opened this issue Nov 12, 2023 · 3 comments · Fixed by #3387
Closed

compute_regionally must be deprecated #3386

navidcy opened this issue Nov 12, 2023 · 3 comments · Fixed by #3387
Labels
documentation 📜 The sacred scrolls question 💭 No such thing as a stupid question

Comments

@navidcy
Copy link
Collaborator

navidcy commented Nov 12, 2023

@simone-silvestri, what is compute_regionally that the docstring here is referring to?

Oceananigans.jl/src/Utils/multi_region_transformation.jl

Line 196 in 7053657

Call `compute_regionally` in case of a returning value and `apply_regionally!`

Legacy/Deprecated perhaps?
@navidcy navidcy added question 💭 No such thing as a stupid question documentation 📜 The sacred scrolls labels Nov 12, 2023
@simone-silvestri
Copy link
Collaborator

It's here
https://github.com/CliMA/Oceananigans.jl/blob/main/src/Utils/multi_region_transformation.jl#L143

@navidcy
Copy link
Collaborator Author

navidcy commented Nov 12, 2023

oh construct_regionally, not compute_regionally. Gotcha!

@simone-silvestri
Copy link
Collaborator

Yeah, so I guess this docstring is deprecated. Let's change it

@navidcy navidcy mentioned this issue Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation 📜 The sacred scrolls question 💭 No such thing as a stupid question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docs for @apply_regionally CliMA/Oceananigans.jl
2 participants
@navidcy @simone-silvestri