Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes parameters name from p to params #1931

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Conversation

tomchor
Copy link
Collaborator

@tomchor tomchor commented Aug 10, 2021

The named tuple that contains parameters in named p in a couple of functions in the convecting plankton example. I think this is unnecessarily confusing since the plankton concentration P appears in the same lines. This fixes that.

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@tomchor tomchor merged commit adf0822 into master Aug 10, 2021
@navidcy navidcy deleted the tc/plankton-example branch September 29, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants