Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split tests into smaller bits and pieces (take #2) #2151

Merged
merged 7 commits into from
Jan 16, 2022
Merged

Split tests into smaller bits and pieces (take #2) #2151

merged 7 commits into from
Jan 16, 2022

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Jan 15, 2022 •
edited
Loading

This is a second take on #2140. Closes #2139.

@navidcy navidcy requested a review from glwagner January 15, 2022 01:24
@navidcy navidcy added the testing 🧪 Tests get priority in case of emergency evacuation label Jan 15, 2022
glwagner
glwagner approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think we should also move some GPU tests to tartarus, but we can do this here or later.

@navidcy
Copy link
Collaborator Author

navidcy commented Jan 15, 2022

Do as you please!

@navidcy
Copy link
Collaborator Author

navidcy commented Jan 15, 2022

If tests pass then I suggest we merge and leave further work for future PR (perhaps after OSM?)

@navidcy navidcy added the GPU 👾 Where Oceananigans gets its powers from label Jan 15, 2022
@navidcy navidcy merged commit 94d55b3 into main Jan 16, 2022
@navidcy navidcy deleted the ncc/split-tests-take2 branch January 16, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

@simone-silvestri simone-silvestri Awaiting requested review from simone-silvestri

Assignees
No one assigned
Labels
GPU 👾 Where Oceananigans gets its powers from testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU tests take way too long
2 participants
@navidcy @glwagner