-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small changes to tilted bottom boundary layer example #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand what you mean in the second point with "we were using ordered arguments". The way the example was written was such that "the order of the kwargs was not important". Syntax f(; x, y, z) is the same as f(x=x, y=y, z=z) and the order does not matter, e.g. julia> x=1; y=2; z=3;
julia> function f(; x=0, y=0, z=0)
@show x
@show y
@show z
return x+y+z
end
f (generic function with 1 method)
julia> f(; x, y, z)
x = 1
y = 2
z = 3
6
julia> f(; y, z, x)
x = 1
y = 2
z = 3
6
|
navidcy
reviewed
Feb 21, 2023
navidcy
reviewed
Feb 21, 2023
navidcy
reviewed
Feb 21, 2023
navidcy
reviewed
Feb 21, 2023
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
navidcy
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait for #2922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
two thingsabout the BBL example:κ
was used for both the von Karman constant and for the eddy diffusivity. Now it's just used for the von Karman constantWhen callingNonhydrostaticModel
we were using ordered arguments, which could make a new user interpret that they should know the order of the arguments when callingNonhydrostaticModel
. Now this call is made in a more usual way with keyword arguments, where the order doesn't matter.