-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify user interface for KernelFunctionOperation
#2964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good to me. It's breaking change so bump up minor release.. |
sounds good |
navidcy
approved these changes
Mar 8, 2023
KernelFunctionOperation
Good idea |
Is #2842 close? |
some tests didn't make it through |
something seems to have broken for GPU? |
No need to bump release since we didn’t register v0.80.0 yet |
tomchor
approved these changes
Mar 15, 2023
simone-silvestri
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the kwargs
computed_dependencies
andparameters
. Instead we just have "arguments", which are varargs to the constructor:compute!
onKernelFunctionOperation
callscompute!
on all of the kernel arguments.I think this is a simpler and more intuitive interface leading to more understandable code.