-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes typo in abstract_scalar_biharmonic_diffusivity_closure.jl
#2968
Conversation
src/TurbulenceClosures/abstract_scalar_biharmonic_diffusivity_closure.jl
Outdated
Show resolved
Hide resolved
…closure.jl Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
@navidcy's comment made me realize that Oceananigans.jl/src/TurbulenceClosures/abstract_scalar_diffusivity_closure.jl Lines 3 to 8 in 9e44b44
And while that is correct, it may be a bit misleading to users since we can use |
Hm no I don't think it's correct. |
src/TurbulenceClosures/abstract_scalar_biharmonic_diffusivity_closure.jl
Outdated
Show resolved
Hide resolved
…closure.jl Co-authored-by: Gregory L. Wagner <wagner.greg@gmail.com>
I changed the text according to your comment. But just to note, I said that is technically correct because the naming given there uses the work isotropic when the ν doesn't change in the directions of the formulation: Oceananigans.jl/src/TurbulenceClosures/abstract_scalar_diffusivity_closure.jl Lines 16 to 28 in 75820d6
Which, again, I think it's a bit misleading, but afaik it's technically correct. |
It's just that "horizontally isotropic" is not the same thing as "isotropic". What is misleading? |
sorry, nvmd, I'm explaning myself poorly. Nothing is misleading anymore since I removed the word "isotropic" in the last commit. We're good to merge whenever tests pass. |
No description provided.