Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenize interface for initializing Simulation, schedules, etc #3015

Merged
merged 9 commits into from
Mar 27, 2023

Conversation

glwagner
Copy link
Member

This PR homogenizes the interface for initializing things: models, simulations, callbacks, schedules.

It also makes it so SpecifiedTimes schedules do not actuate at iteration 0 unless time=0 is contained in the schedule.

Closes #2719

@glwagner glwagner changed the title Homogenize inteface for initializing Simulation, schedules, etc Homogenize interface for initializing Simulation, schedules, etc Mar 23, 2023
@glwagner
Copy link
Member Author

glwagner commented Mar 24, 2023

Looking at this PR, I think we should make a few structural changes:

  • Move AbstractSchedule to Simulations. This is where it belongs? (not Utils)
  • Make schedules a function of Simulation, not model.

I don't think users really care --- it's just more logical I think this way. It's about homogenizing the Simulation/AbstractModel interface I guess.

@navidcy
Copy link
Collaborator

navidcy commented Mar 27, 2023

merge?

@glwagner glwagner merged commit fb9e9c5 into main Mar 27, 2023
@glwagner glwagner deleted the glw/initialize-better branch March 27, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callback with SpecifiedTimes also gets called in iteration 0
2 participants