Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CutCellBottom #3146

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Implement CutCellBottom #3146

wants to merge 4 commits into from

Conversation

siddharthabishnu
Copy link
Contributor

This PR closes #3123.

@siddharthabishnu
Added visualization of tracer concentration
41b8f47 
(a) Created an animation of the time evolution of the tracer concentration over
    the Gaussian bump;
(b) Fixed minor bugs and compacted certain lines of code.
@siddharthabishnu
First attempt at shaved cells
fa4c5e3
@siddharthabishnu
Renamed shaved cells to cut cells everywhere
0540736
@navidcy navidcy added numerics 🧮 So things don't blow up and boil the lobsters alive immersed boundaries ⛰️ Less Ocean, more anigans labels Jun 14, 2023
@glwagner glwagner changed the title Cut Cells Implementing CutCellBottom Jun 15, 2023
@glwagner glwagner marked this pull request as draft June 15, 2023 01:09
@glwagner
Copy link
Member

@siddharthabishnu I made the title more verbose and converted to draft, feel free to change if you like

@siddharthabishnu
Improved visualization and plotted topography
0e27c04 
(a) Added options to switch between:
    (i)  full cells, partial cells, and (not yet working) cut cells;
    (ii) plotting the heatmaps and the filled contours of the time evolution of
         the tracer concentration;
(b) Plotted the analytical profile of the Gaussian bump as a benchmark for
    comparison of its discrete counterparts using full, partial, and cut cells.
@siddharthabishnu
Copy link
Contributor Author

@siddharthabishnu I made the title more verbose and converted to draft, feel free to change if you like

I like the new version of the title, and I wasn't sure how to create a draft PR. So, thanks.

@glwagner glwagner changed the title Implementing CutCellBottom Implements CutCellBottom Jul 11, 2023
@glwagner glwagner changed the title Implements CutCellBottom Implement CutCellBottom Jul 11, 2023
@tomchor tomchor mentioned this pull request Jul 15, 2023
Open
@apaloczy apaloczy mentioned this pull request May 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
immersed boundaries ⛰️ Less Ocean, more anigans numerics 🧮 So things don't blow up and boil the lobsters alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing a CutCellBottom immersed boundary
3 participants
@siddharthabishnu @glwagner @navidcy