-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalization of OrthogonalSphericalShellGrid
to be able to construct any grid with coords-metrics that vary in both i, j
#3230
Conversation
Maybe show us what the syntax would look like to construct a lat lon grid? or a lat lon grid with a displaced pole? |
I’ll add an example in the docstring. |
and paste here? |
|
OK, so what you are asking here implicitly is that this PR also deals (at least partly) with #3205? |
I think I'd rather deal with #3205 in a different PR. |
Oh no problem. I think there could even be more than one PR. First we just want to show that we can build a latitude longitude grid using OSSG. next we can test dynamics on OSSG and make sure its identical (that's a better test than just visualizing a splash). Then we can design a user interface that makes it easy to build latitdue longitude grid or any other grid on OSSG. Then we can deprecate latitude longitude grid. So there's a lot of ways to break it up. I just thought if OSSG works it'd be nice to demonstrate by running a case on lat lon grid. |
I'll do that on a new PR! I'm merging this which is mostly name-change for the constructor and some sorting of conformal mapping related properties together to make OSSG grid more generic. |
(Well I guess I'll merge after somebody approves... hint hint) |
…uct any grid with coords-metrics that vary in both `i, j` (#3230) * generalize ossg + group conformal-related properties together * add convenience constructor for non-conformal related OSSG * fix grid tests * fix test * fix code alignment * fix adapt OSSG * fix doctest * fix doctest
This PR removes any conformal mapping-related properties from the
OrthogonalSphericalShellGrid
and thus nowOrthogonalSphericalShellGrid
is any grid with coordinates and metrics that depend on both horizontal dimensions. The PR also adds aconformal_cubed_sphere_panel
constructor that returns the grid that corresponds to each panel of a conformal cubed sphere grid.Closes #3200