Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalization of OrthogonalSphericalShellGrid to be able to construct any grid with coords-metrics that vary in both i, j #3230

Merged
merged 10 commits into from
Aug 29, 2023

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Aug 24, 2023

This PR removes any conformal mapping-related properties from the OrthogonalSphericalShellGrid and thus now OrthogonalSphericalShellGrid is any grid with coordinates and metrics that depend on both horizontal dimensions. The PR also adds a conformal_cubed_sphere_panel constructor that returns the grid that corresponds to each panel of a conformal cubed sphere grid.

Closes #3200

@glwagner
Copy link
Member

Maybe show us what the syntax would look like to construct a lat lon grid? or a lat lon grid with a displaced pole?

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 24, 2023

I’ll add an example in the docstring.

@glwagner
Copy link
Member

and paste here?

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 24, 2023

and paste here?
For sure

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 25, 2023

Maybe show us what the syntax would look like to construct a lat lon grid? or a lat lon grid with a displaced pole?

OK, so what you are asking here implicitly is that this PR also deals (at least partly) with #3205?
Because as it stands now, there is no convenience constructor to create a lat-lon OrthogonalSphericalShellGrid; you can just create it using the struct constructor. Is this what you'd like to see an example of? It will involve manually creating the arrays with the lat, lon values and the metrics and then provide it to the OrthogonalSphericalShellGrid constructor.

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 29, 2023

I think I'd rather deal with #3205 in a different PR.

@glwagner
Copy link
Member

Oh no problem. I think there could even be more than one PR. First we just want to show that we can build a latitude longitude grid using OSSG. next we can test dynamics on OSSG and make sure its identical (that's a better test than just visualizing a splash). Then we can design a user interface that makes it easy to build latitdue longitude grid or any other grid on OSSG. Then we can deprecate latitude longitude grid. So there's a lot of ways to break it up. I just thought if OSSG works it'd be nice to demonstrate by running a case on lat lon grid.

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 29, 2023

I'll do that on a new PR! I'm merging this which is mostly name-change for the constructor and some sorting of conformal mapping related properties together to make OSSG grid more generic.

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 29, 2023

(Well I guess I'll merge after somebody approves... hint hint)

@navidcy navidcy merged commit f8b4936 into main Aug 29, 2023
47 checks passed
@navidcy navidcy deleted the ncc/ossg branch August 29, 2023 14:21
siddharthabishnu pushed a commit that referenced this pull request Sep 11, 2023
…uct any grid with coords-metrics that vary in both `i, j` (#3230)

* generalize ossg + group conformal-related properties together

* add convenience constructor for non-conformal related OSSG

* fix grid tests

* fix test

* fix code alignment

* fix adapt OSSG

* fix doctest

* fix doctest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants