Enzyme: try bump without tuple changes #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
reviewed
Jun 13, 2024
test/test_enzyme.jl
Outdated
| autodiff(Enzyme.Reverse, | ||
| set_initial_condition!, | ||
| Duplicated(model, dmodel), | ||
| Active(1.0)) |
There was a problem hiding this comment.
some indendenting irregularities here and above
glwagner
approved these changes
Jun 13, 2024
glwagner
reviewed
Jun 13, 2024
src/Utils/kernel_launching.jl
Outdated
Comment on lines
117
to
119
| include_right_boundaries = false, | ||
| reduced_dimensions = (), | ||
| location = nothing, |
|
seems simple enough, just a few cosmetic comments. Does |
vchuravy
reviewed
Jun 22, 2024
Project.toml
Outdated
| @@ -11,6 +11,7 @@ CubedSphere = "7445602f-e544-4518-8976-18f8e8ae6cdb" | |||
| Dates = "ade2ca70-3891-5945-98fb-dc099432e06a" | |||
| Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7" | |||
| DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae" | |||
| Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9" | |||
There was a problem hiding this comment.
Should be in [extras] if it is just a testdep
|
@navidcy @glwagner this should superceded all previous enzyme prs (including compatbwlper), which I've gone ahead and closed just now. Some non enzyme tests had a nondeterministic ci failure about a directory not being empty, but otherwise all pass (incl enzyme tests). Once landed we should add a lot more integration test cases like @jlk9 your flux boundary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires EnzymeAD/Enzyme.jl#1485 to release, which itself requires JuliaRegistries/General#108556
Perhaps means we don't change the other varargs stuff, but we'll have to wait and see.