Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes package name to ParameterEstimocean #234

Merged
merged 1 commit into from Mar 28, 2022
Merged

Changes package name to ParameterEstimocean #234

merged 1 commit into from Mar 28, 2022

Conversation

glwagner
Copy link
Member

No description provided.

@navidcy
Copy link
Collaborator

navidcy commented Mar 21, 2022

Do we have to?

@glwagner
Copy link
Member Author

@adelinehillier @navidcy likes OceanLearning!

navidcy
navidcy approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let鈥檚 do it

@navidcy navidcy merged commit 3dd370b into main Mar 28, 2022
@navidcy navidcy deleted the parameter-estimocean branch March 28, 2022 04:57
@navidcy
Copy link
Collaborator

navidcy commented Mar 28, 2022

Ooops... was it still under vote?

@glwagner
Copy link
Member Author

ParameterEstimocean.jl won the day 5-3 (note that I hadn't voted yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidcy navidcy navidcy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glwagner @navidcy